-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kstatus: defaults to fail open when no status
field is available
#632
Comments
One thing that we have been doing is to patch the logic for every custom CRD that we create. It's not great, but we also don't have a lot of custom CRDs. |
If I am reading the code right ( cli-utils/pkg/kstatus/status/status.go Line 102 in 0b156cb
Current if there is no status field.
|
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
This is correct. Objects without status are assumed to be Current. This is how many of the base k8s types are handled, like Role & RoleBinding, which don't have status. If you want your CRD to not immediately be seen as Current, add |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
TL;DR - When a resource doesn't yet have a
status
field does kstatus reportunknown
?When creating a resource which is defined by a CRD which has no
status
by default, i believe the behaviour of kstatus is to state "unknown". I believe this then enables developers usingunknown
as a condition to determine if that should be seen as "lets carry on" or "stop here and wait".If the "unknown" status is indeed what happens when no
status
field exists on a resource (because it has been freshly applied and the backing controller hasn't had a chance to update the CR' status field yet, i'll close this issue and raise another with the project using this one to add configuration.The text was updated successfully, but these errors were encountered: