Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support additional fields for GKE #906

Closed
1 of 4 tasks
akshay196 opened this issue Apr 30, 2023 · 21 comments · Fixed by #1186
Closed
1 of 4 tasks

Support additional fields for GKE #906

akshay196 opened this issue Apr 30, 2023 · 21 comments · Fixed by #1186
Assignees
@akshay196 @aniruddha2000
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@akshay196
Copy link
Contributor

akshay196 commented Apr 30, 2023 •
edited
Loading

/kind feature

Describe the solution you'd like

CAPG initial support for Managed Cluster (GKE) has added few basic configurations. GCP does support lot more fields for example private cluster, enable workload identity, just to name a few. This is a request to add support for more fields than just basics.

This spreadsheet enlists all important GKE configuration we can support in GCPManaged* kinds.

All additional GKE fields are documented in the spreadsheet linked above. The structure in spreadsheet can be used for defining GCPManaged API specs. Feel free to comment to discuss more about any fields.

Anything else you would like to add:

There are other open issues those requested for additional fields too:

Such requests can be tackled by the complete list (spreadsheet) attached here.

If this sounds good then, I am happy to take this forward and decide sub-tasks for better collaboration.

looping @poornima-rafay @niravparikh05

Progress

Tasks - PR1
Beta Give feedback

Tasks - PR2
Beta Give feedback

Tasks - PR3
Beta Give feedback

Tasks - PR4
Beta Give feedback
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 30, 2023
@aniruddha2000
Copy link
Contributor

@akshay196 I am happy to get involved in the dividing task discussion and take some of them.

@richardcase
Copy link
Member

That spreadsheet is really helpful @akshay196 👍

It would be good to split the work into smaller chunks to make the review easier and also the addition of e2e tests.

@akshay196
Copy link
Contributor Author

Updated spreadsheet with more details. Added task list above.

@aniruddha2000
Copy link
Contributor

Thanks for the update @akshay196 , have you started working on anything? If not I will start adding fields one by one and open a tracking PR.

@aniruddha2000
Copy link
Contributor

/assign

@akshay196
Copy link
Contributor Author

@aniruddha2000 Started adding username in tasks list for taking ownership of tasks.

@aniruddha2000 aniruddha2000 mentioned this issue May 31, 2023
Closed
2 tasks
@aniruddha2000
Copy link
Contributor

@akshay196 I have created the PR for my first task #936 feel free to link it with the description tasks. Also, could you have a look into it? I officially cannot make you a reviewer because you are not in the k8s-sig org.

@aniruddha2000
Copy link
Contributor

aniruddha2000 commented Jun 2, 2023 •
edited
Loading

I have started looking in the Reconciliation loop of the same, could you update the description by adding my name beside reconciliation loop for GCPManagedControlPlane @akshay196 ?

@jayesh-srivastava
Copy link
Member

Hi @aniruddha2000 @akshay196 If there's room for more, would like to contribute as well.

@aniruddha2000
Copy link
Contributor

aniruddha2000 commented Jun 2, 2023 •
edited
Loading

@jayesh-srivastava Sure, you can look into the webhooks part of GCPManagedControlPlane maybe, I think we need to discuss what kind of webhooks are required after all of the fields are up.

@jayesh-srivastava
Copy link
Member

Sounds good @aniruddha2000. @akshay196 Can you please update the description and assign the webhook tasks to me?

@sayantani11
Copy link
Contributor

Hello @aniruddha2000 @jayesh-srivastava long time no see!!! Would also like to help in the implementation!!! Lemme know if anything is there.

@akshay196-rafay akshay196-rafay mentioned this issue Jun 6, 2023
Merged
2 tasks
@aniruddha2000
Copy link
Contributor

@sayantani11 yes definitely, you can have a look at other webhook

@liticer
Copy link

liticer commented Jun 27, 2023

@aniruddha2000 @jayesh-srivastava How are the latest developments? We want to use these features, and if they could not be ready soon, we would like to build further implementations based on the current code.

@akshay196
Copy link
Contributor Author

Updated tasks above as per discussion here. We have divided GCPManagedControlPlane additional fields into two. We will raise PR that includes set of new fields, respective reconciliation loop changes, webhooks and e2e if any.
cc @aniruddha2000 You will need to update your PR.

Task 3 is up for anyone interested.

@richardcase richardcase mentioned this issue Oct 26, 2023
Closed
@akshay196
Copy link
Contributor Author

Tagging Tasks - PR3 to myself and start working on it.

@akshay196
Copy link
Contributor Author

/assign

@akshay196
Copy link
Contributor Author

Aniruddha is not working on Tasks - PR2. It is open for anyone interested.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2024
@akshay196
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2024
@akshay196-rafay akshay196-rafay mentioned this issue Mar 20, 2024
Merged
3 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshay196 akshay196

@aniruddha2000 aniruddha2000

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support additional GCPManagedControlPlane fields akshay196-rafay/cluster-api-provider-gcp-fork
8 participants
@richardcase @liticer @akshay196 @k8s-ci-robot @aniruddha2000 @jayesh-srivastava @k8s-triage-robot @sayantani11