-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider no longer handles pagination in Metal API endpoints #630
Comments
Anywhere that we are listing is somewhere that we could miss the desired resource by not paginating. Some examples:
(These are the only |
@cprivitere points out that the EM API spec for these functions do not explicitly say that the results are paginated, they say that they return "all" of the resources. |
Does this issue still need to be addressed? Both Those automatic pagination methods should provide equivalent behavior to what the previous |
As @ctreatma points out, this is no longer necessary. |
The SDK provides pagination functions now, but I don't think we're using them yet in this project. I only see |
What steps did you take and what happened:
N/A; I haven't observed an impact of this bug (depending on how the provider is used--for example, if every cluster has its own project and/or the total number of devices is less than the default page size for the devices API--it doesn't necessarily have an impact.
What did you expect to happen:
For Metal API endpoints that include pagination details (a
meta
object with current page, total number of pages, etc.), the provider should automatically navigate pagination. Alternatively: auto-page-navigation support could be added as a feature inmetal-go
and this provider updated to use that new features.Anything else you would like to add:
The
pager
module inmetal-cli
is a good reference for implementing auto-page-navigation in ametal-go
-based tool: https://github.com/equinix/metal-cli/blob/main/internal/pagination/pager.goEnvironment:
kubectl version
):/etc/os-release
):The text was updated successfully, but these errors were encountered: