Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to understand if a ClusterClass is ready #8137

Open
Tracked by #10852
sbueringer opened this issue Feb 20, 2023 · 8 comments
Open
Tracked by #10852

Make it easier to understand if a ClusterClass is ready #8137

sbueringer opened this issue Feb 20, 2023 · 8 comments
Labels
area/clusterclass Issues or PRs related to clusterclass help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

sbueringer commented Feb 20, 2023

Today ClusterClass has a VariablesReconciled and a RefVersionsUpToDate condition
observedGeneration is (as usual) only set if a ClusterClass is reconciled without any errors.

Goal of this issue is to make it easier for users to see if a ClusterClass is ready, one way to to this would be to introduce a Ready condition which summarizes the state of the other conditions.

Then users only have to check for the Ready condition and not all conditions.

/area topology
/kind feature

@k8s-ci-robot k8s-ci-robot added area/topology kind/feature Categorizes issue or PR as related to a new feature. labels Feb 20, 2023
@sbueringer
Copy link
Member Author

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 20, 2023
@oscr
Copy link
Contributor

oscr commented Feb 20, 2023

I think encoding the requirements for a CC to be ready is a clear improvement for users. Great suggestion

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 20, 2023
@killianmuldoon killianmuldoon added the area/clusterclass Issues or PRs related to clusterclass label May 4, 2023
@vincepri
Copy link
Member

vincepri commented Jul 6, 2023

Is this readiness in the context of initialization?

@sbueringer
Copy link
Member Author

sbueringer commented Jul 6, 2023

What do you mean with "initialization"?

The idea was to make it easier to understand if a ClusterClass is reconciled so a Cluster can be reconciled.

This is relevant after initial deployment of the ClusterClass, but also later if a ClusterClass is updated.

@vincepri
Copy link
Member

vincepri commented Jul 6, 2023

Got it, so Ready might change over time if there are changes on the ClusterClass itself that needs to be reconciled. I meant initialization as a first sync, somewhat like when a control plane gets initialized (which might fall into a different condition), just wanted to clarify

@sbueringer
Copy link
Member Author

Ah got it. Yup, Ready can flicker back and forth.

@fabriziopandini
Copy link
Member

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 11, 2024
@fabriziopandini
Copy link
Member

/kind api-change

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Apr 11, 2024
@fabriziopandini fabriziopandini added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterclass Issues or PRs related to clusterclass help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

6 participants