Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draining can block transparently a scalable resource scale down / delete operation #9285

Closed
enxebre opened this issue Aug 23, 2023 · 3 comments · Fixed by #9355
Closed

Draining can block transparently a scalable resource scale down / delete operation #9285

enxebre opened this issue Aug 23, 2023 · 3 comments · Fixed by #9355
Assignees
Labels
area/machine Issues or PRs related to machine lifecycle management kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@enxebre
Copy link
Member

enxebre commented Aug 23, 2023

What steps did you take and what happened?

Another use case where more signalling in the scalable resource ie. MachineDeployment / MachineSet would be useful is when drain is permanently blocked by e.g. a pdb. Right now there's no way to understand draining is preventing a scaling down / deletion operation from succeeding by looking at the MD/MS status.

May be DrainingSucceededCondition when present could be included in the machine ready summary which would be able up into machineSets via MachinesReadyCondition and so into MachineDeployments via #9262

What did you expect to happen?

As an entity interacting with MD/MS I can understand draining is blocking scale down / deletion

Cluster API version

latest

Kubernetes version

No response

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 23, 2023
@sbueringer
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 23, 2023
@sbueringer sbueringer added area/machine Issues or PRs related to machine lifecycle management needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Aug 23, 2023
@typeid
Copy link
Contributor

typeid commented Aug 31, 2023

/assign

@enxebre
Copy link
Member Author

enxebre commented Aug 31, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/machine Issues or PRs related to machine lifecycle management kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants