Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluecat: refactor gateway api REST calls into separate package #2187

Closed
seanmalloy opened this issue Jul 21, 2021 · 6 comments · Fixed by #2696
Closed

bluecat: refactor gateway api REST calls into separate package #2187

seanmalloy opened this issue Jul 21, 2021 · 6 comments · Fixed by #2696
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@seanmalloy
Copy link
Member

Currently the Go code for making API calls to the BlueCat Gateway is mixed in with the k8s external-dns BlueCat provider code(provider/bluecat/bluecat.go. The BlueCat Gateway does not provide a Go package for making REST API calls.

The Go code for making REST API calls to the BlueCat Gateway should be refactored into a separate package. For example provider/bluecat/api/api.go.
@seanmalloy seanmalloy added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 21, 2021
@seanmalloy
Copy link
Member Author

/kind cleanup
/remove-kind feature

FYI @vinny-sabatini @sanbornick @seegeekrow @trzejos

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jul 21, 2021
@seanmalloy seanmalloy changed the title bluecat: refactor gateway api calls into separate package bluecat: refactor gateway api REST calls into separate package Jul 21, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 19, 2021
@seanmalloy
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 19, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2022
@vinny-sabatini
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 21, 2022
@vinny-sabatini
Copy link
Contributor

I have started working on this effort here - https://github.com/kohlstechnology/external-dns/tree/issue-2187

@vinny-sabatini vinny-sabatini mentioned this issue Apr 8, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

extract bluecat api code into its own package KohlsTechnology/external-dns
4 participants
@seanmalloy @vinny-sabatini @k8s-ci-robot @k8s-triage-robot