Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Pending" reason and document usage for condition "Accepted", status: "Unknown" on all resources #1449

Closed
7 tasks done
mikemorris opened this issue Oct 10, 2022 · 0 comments · Fixed by #1453
Closed
7 tasks done

Add "Pending" reason and document usage for condition "Accepted", status: "Unknown" on all resources #1449

mikemorris opened this issue Oct 10, 2022 · 0 comments · Fixed by #1453
Assignees
@youngnick
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.6.0

Comments

@mikemorris
Copy link
Contributor

mikemorris commented Oct 10, 2022 •
edited by youngnick
Loading

What would you like to be added:

  • Add a new "Pending" status condition reason to match the existing ListenerConditionReason
    • GatewayClassConditionReason
    • GatewayConditionReason
    • RouteConditionReason
  • Document that ListenerReasonPending should be used when the ListenerConditionAccepted status is Unknown.
  • Deprecate GatewayClassReasonWaiting and standardize description
  • Deprecate GatewayReasonNotReconciled and standardize description

Why this is needed:

GEP-1364 clarified that the Accepted condition should always be set, even when the status would be "Unknown", and the reason field on Condition is required.
@mikemorris mikemorris added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 10, 2022
@mikemorris mikemorris mentioned this issue Oct 10, 2022
Closed
7 tasks
@robscott robscott added this to the v0.6.0 milestone Oct 10, 2022
@shaneutt shaneutt added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 11, 2022
@youngnick youngnick self-assigned this Oct 11, 2022
@youngnick youngnick mentioned this issue Oct 11, 2022
Merged
@mikemorris mikemorris changed the title Document expected Reason for Condition Accepted, status: Unknown on all resources Add "Pending" reason and document usage for condition "Accepted", status: "Unknown" on all resources Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youngnick youngnick

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

Add Pending reason to GatewayClass, Gateway, Listener, and Routes youngnick/gateway-api
4 participants
@robscott @mikemorris @shaneutt @youngnick