Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels and taints are missing on the nodes that karpenter node pools bring up #1634

Open
janani2019 opened this issue Sep 4, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@janani2019
Copy link

Description

Observed Behavior:
When I do a describe node on any of the nodes that the karpenter nodepool brings up, I expect to see the taints and labels applied.
Expected Behavior:
The taints and labels are not applied
Reproduction Steps (Please include YAML):
apiVersion: karpenter.sh/v1
kind: NodePool
metadata:
name: imagebuild
spec:
template:
metadata:
labels:
type: ImageBuilder
spec:
expireAfter: 19m
terminationGracePeriod: 20m
requirements:
- key: kubernetes.io/arch
operator: In
values: ["amd64"]
- key: kubernetes.io/os
operator: In
values: ["linux"]
- key: karpenter.sh/capacity-type
operator: In
values: ["on-demand"]
- key: karpenter.k8s.aws/instance-category
operator: In
values: ["c", "m", "r"]
- key: karpenter.k8s.aws/instance-generation
operator: Gt
values: ["2"]
- key: node.kubernetes.io/instance-type
operator: Exists
minValues: 10
nodeClassRef:
group: karpenter.k8s.aws
kind: EC2NodeClass
name: default
taints:
- key: images_build_workload
effect: NoSchedule
limits:
cpu: 1000
memory: 1000Gi
disruption:
consolidationPolicy: WhenEmptyOrUnderutilized
consolidateAfter: 20m

Versions:

  • Chart Version: karpenter v1.1.0
  • Kubernetes Version (kubectl version):
@janani2019 janani2019 added the kind/bug Categorizes issue or PR as related to a bug. label Sep 4, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Karpenter contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 4, 2024
@janani2019 janani2019 changed the title Labels and taints are missing not nodes that karpenter node pools bring up Labels and taints are missing on the nodes that karpenter node pools bring up Sep 5, 2024
@engedaam
Copy link
Contributor

engedaam commented Sep 9, 2024

Are the labels present on nodeclaimtemplatespec? https://karpenter.sh/docs/concepts/nodepools/#spectemplatemetadatalabels. Seem like the labels are on the nodepool metadata. Can you share a node that is owned by the nodepool and does not contain the taint specified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants