-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the controller-gen markers in types.go if the --plural is specified #1805
Comments
Hi @Adirio and @prafull01, Could not it be addressed in the #1802 as well? |
I think that this is more a bug that should be addressed while the other is an added feature |
Hi @prafull01, See the comment #1802 (review), shows that we have a bug related to pluralize. I am not sure if we should add this option |
This option is already present in the webhook api creation of the kubebuilder, however the name of this option is For example, this command generates the following markers (please check the Plurals Frigatees):
IMHO If we are providing this option for webhook, then we should provide same option for api creation as well or not provide at all for both. |
IMHO, markers should be added if required to fix |
This is a follow up of the following PR: #1802
Controller-gen markers for apis should be added if the specific plural is provided by the user. Lets consider the following scenario:
PROJECT file:
CRD file:
It should add marker (here) in the api/_types.go file which will actually add the plurals in the CRD as well.
/kind bug
The text was updated successfully, but these errors were encountered: