Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise multiple ansible versions in CI #8166

Closed
cristicalin opened this issue Nov 7, 2021 · 1 comment · Fixed by #8172
Closed

Exercise multiple ansible versions in CI #8166

cristicalin opened this issue Nov 7, 2021 · 1 comment · Fixed by #8172
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@cristicalin
Copy link
Contributor

What would you like to be added:
CI jobs for supported ansible versions.

Why is this needed:
We claim that we support ansible 2.9 and 2.10 (actually 3.x) and we also have requests to support ansible 2.11 (actually 4.x). We would need to cover these different versions in CI to be able to reliably know we did not inadvertently break a version we don't exercise in CI (like #8160).

My proposal is to move https://github.com/kubernetes-sigs/kubespray/blob/master/requirements.txt and https://github.com/kubernetes-sigs/kubespray/blob/master/tests/requirements.txt to a versioned requirements.txt (say requirements-2.10.txt) and link the default one to the requirements.txt and add for each supported version a requirements-2.x.txt versioned file. In addition to this we would need to modify https://github.com/kubernetes-sigs/kubespray/blob/master/tests/scripts/testcases_prepare.sh to allow test cases to specifiy the ansible versions and add at least one job for each supported ansible version with a default aio config.

@cristicalin cristicalin added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 7, 2021
@floryut
Copy link
Member

floryut commented Nov 8, 2021

Not a bad idea at all, and indeed not that much of work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants