Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCE] support reusing existing ssh keys #109

Closed
amwat opened this issue Mar 11, 2021 · 2 comments · Fixed by #117
Closed

[GCE] support reusing existing ssh keys #109

amwat opened this issue Mar 11, 2021 · 2 comments · Fixed by #117
Labels
sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone
v0.1.0

Comments

@amwat
Copy link
Contributor

amwat commented Mar 11, 2021

/cc @spiffxp
xref: kubernetes/k8s.io#1751 (comment)

xref: kubernetes/enhancements#2464
@amwat
Copy link
Contributor Author

amwat commented Mar 12, 2021

I'd like to deprecate "JENKINS" while doing this

https://github.com/kubernetes/test-infra/blob/31c626f6a2e660c8cf8d44b417cb5a71d0d63dba/config/prow/config.yaml#L639-L647

best way would be to export the same files as both JENKINS_GCE_SSH_PRIVATE_KEY_FILE ,GCE_SSH_PRIVATE_KEY_FILE and JENKINS_GCE_SSH_PUBLIC_KEY_FILE, GCE_SSH_PUBLIC_KEY_FILE

as part of preset-k8s-ssh so that both kubetest and kubetest2 jobs can use the same preset.

kubetest2 will rely only on GCE_SSH_PRIVATE_KEY_FILE and GCE_SSH_PUBLIC_KEY_FILE

thoughts @spiffxp ?

@spiffxp
Copy link
Member

spiffxp commented Mar 14, 2021

SGTM

@spiffxp spiffxp mentioned this issue Mar 17, 2021
Merged
@amwat amwat added this to the v0.1.0 milestone Mar 17, 2021
@amwat amwat mentioned this issue Mar 23, 2021
Merged
@amwat amwat mentioned this issue Mar 29, 2021
Merged
@spiffxp spiffxp mentioned this issue Apr 1, 2021
Closed
@amwat amwat mentioned this issue Apr 5, 2021
Merged
@spiffxp spiffxp added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

[GCE] Allow reusing ssh keys in CI amwat/kubetest2
2 participants
@spiffxp @amwat