Add DeployerWithPostTester interface #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @amwat |
amwat
reviewed
Mar 9, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This allows the deployer to define after-test behavior based on the results of the test. Unfortunately PostTest can't be wrapped in writer.WrapStep because PostTest has an error parameter but WrapStep expects `func() error`
k8s-ci-robot
removed
the
lgtm
|
@amwat I resolved the merge conflicts, PTAL |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the deployer to define after-test behavior based on the results of the test.
Unfortunately PostTest can't be wrapped in writer.WrapStep because PostTest has an error parameter but WrapStep expects
func() error. Ideally it could be wrapped in a step so we can see its results in testgrid.If both test.Run and PostTest return errors, PostTest's error is returned.
Closes #102