Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MultiKueue] Report ClusterQueue as inactive (misconfigured) if not applied to all flavors #2021

Closed
mimowo opened this issue Apr 19, 2024 · 3 comments · Fixed by #2047
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mimowo
Copy link
Contributor

mimowo commented Apr 19, 2024

What would you like to be added:

Fail validation for ClusterQueue in case the MultiKueue admission check is configured only for a subset of flavors.
This can be now done with a similar mechanism to this: #1913.

Why is this needed:

The managedBy field is immutable, so we cannot change it per flavor.
To fail fast and avoid debugging of customer issues when using MultiKueue for a subset of flavors.

Proposed approach

A mechanism similar to this one: #1635

@mimowo mimowo added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 19, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Apr 19, 2024

/assign @trasc
/cc @alculquicondor

@IrvingMg
Copy link
Contributor

/assign

@mimowo mimowo changed the title [MultiKueue] Report ClusterQueue as inactive (miconfigured) if not applied to all flavors [MultiKueue] Report ClusterQueue as inactive (misconfigured) if not applied to all flavors Apr 22, 2024
@alculquicondor
Copy link
Contributor

as a clarification: an admission check applies to all flavors if the list in onFlavors is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants