Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the QueueVisibility feature gate and corresponding API #2256

Closed
PBundyra opened this issue May 22, 2024 · 10 comments · Fixed by #3110
Closed

Deprecate the QueueVisibility feature gate and corresponding API #2256

PBundyra opened this issue May 22, 2024 · 10 comments · Fixed by #3110
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@PBundyra
Copy link
Contributor

What would you like to be cleaned:
I suggest coming with a plan to deprecate the QueueVisibility API. I would start with deprecating the QueueVisiblity feature gate and deleting logic behind it, and then remove the visibility field from ClusterQueue's Status when migrating to a next beta version of Kueue API.

Why is this needed:
There was the visibility API introduced that covers all business needs that were cover by the QueueVisibility API and more. The visibility API resolves all drawback related to the QueueVisibility API and addresses its limitations. For now I don't see a rationale for maintaining the QueueVisiblity API. Additionally I believe having two different ways (and two feature gates) to monitor pending workloads may lead to a little confusion regarding their pros and cons.

@PBundyra PBundyra added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 22, 2024
@PBundyra
Copy link
Contributor Author

@PBundyra
Copy link
Contributor Author

If you agree with this idea I will add this to the v1beta2 wishlist.

@mimowo
Copy link
Contributor

mimowo commented May 22, 2024

Yeah, I never liked the mechanism, but we may want to seek additional community feedback at the batch-wg meeting / slack.

@tenzen-y
Copy link
Member

I agree with you, but let's keep it while v1beta1 for the backward compatibility.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2024
@tenzen-y
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2024
@mimowo
Copy link
Contributor

mimowo commented Sep 11, 2024

I agree with you, but let's keep it while v1beta1 for the backward compatibility.

Keeping for backwards compatibility makes sense, but I think we can already deprecate it, so:

  1. update the kube_features to mention it is deprecated, like here
  2. and also mention it is deprecated in the docs.

@mimowo
Copy link
Contributor

mimowo commented Sep 11, 2024

Just to x-reference the related effort of promoting the VisibilityOnDemand to beta: #2973

@mimowo
Copy link
Contributor

mimowo commented Sep 20, 2024

@mbobrovskyi would you like to continue with this as a follow up to #2973?

@mbobrovskyi
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants