Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update module name #190

Merged
merged 1 commit into from
Jan 6, 2021
Merged

update module name #190

merged 1 commit into from
Jan 6, 2021

Conversation

kbhawkey
Copy link
Contributor

@kbhawkey kbhawkey commented Jan 4, 2021

Testing an <hr> element after type description.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 4, 2021
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Jan 5, 2021

/approve cancel

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Jan 5, 2021

/cc @feloy

@k8s-ci-robot
Copy link
Contributor

@kbhawkey: GitHub didn't allow me to request PR reviews from the following users: feloy.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @feloy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kbhawkey kbhawkey changed the title update module name [wip]update module name Jan 5, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2021
@tengqm
Copy link
Contributor

tengqm commented Jan 5, 2021

@kbhawkey Pls remove (wip) when this is ready.

@kbhawkey
Copy link
Contributor Author

kbhawkey commented Jan 5, 2021

The source builds. I am looking for feedback on the addition of the <hr> element.

@kbhawkey kbhawkey changed the title [wip]update module name update module name Jan 5, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2021
@tengqm
Copy link
Contributor

tengqm commented Jan 5, 2021

/approve

The addition of <hr/> looks good to me too.

Thanks.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
@feloy
Copy link
Contributor

feloy commented Jan 5, 2021

The use of hr looks good to me

@feloy
Copy link
Contributor

feloy commented Jan 5, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

@feloy: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tengqm
Copy link
Contributor

tengqm commented Jan 6, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit d06ff1f into kubernetes-sigs:master Jan 6, 2021
@kbhawkey kbhawkey deleted the test-md-api-gen branch January 6, 2021 00:46
@feloy feloy mentioned this pull request Jan 6, 2021
Closed
feloy added a commit to feloy/website that referenced this pull request Jan 6, 2021
@feloy
Separate resource description from list of resource fields
448f067 
From kubernetes-sigs/reference-docs#190
feloy added a commit to feloy/website that referenced this pull request Jan 6, 2021
@feloy
Separate resource description from list of resource fields
320360e 
From kubernetes-sigs/reference-docs#190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbhawkey @k8s-ci-robot @tengqm @feloy