BUG: Controller never reconciles on update even if secret sync has changed #83
Assignees
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
3 tasks
|
We can either always reconcile on the update or we can separate out the logic for calculating the hash in the reconcile function and then also call it in the shouldReconcile function to calculate the hash of the new object. |
3 tasks
|
/assign |
3 tasks
|
@nilekhc simon on my team proposed this UpdateFunc: func(e event.UpdateEvent) bool {
old, ok := e.ObjectOld.(*secretsyncv1alpha1.SecretSync)
if !ok {
return true
}
new, ok := e.ObjectNew.(*secretsyncv1alpha1.SecretSync)
if !ok {
return true
}
return !reflect.DeepEqual(old.Spec, new.Spec)
},Given the function to calculate the secret hash requires us to also fetch the secret data, this seems like the best option. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps did you take and what happened:
When updating a secretsync, the controller will not re-reconcile a secret on an update.
What did you expect to happen:
I expected the controller to re-reconcile if the secretsync is updated.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
shouldReconcilePredicateis called and then callsprocessIfSecretChangedwhich always returns false because thesyncHashis never updated.Proposed solution is to return true in
shouldReconcilePredicatein the case of anUpdateEventand not callprocessIfSecretChangedWhich provider are you using:
[e.g. Azure Key Vault, HashiCorp Vault, etc. Have you checked out the provider's repo for more help?]
Environment:
kubectl version):The text was updated successfully, but these errors were encountered: