Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster autoscaler more AWS DescribeLaunchTemplateVersions due to PR-6245 #7102

Open
linhua11 opened this issue Aug 1, 2024 · 3 comments · May be fixed by #7383
Open

Cluster autoscaler more AWS DescribeLaunchTemplateVersions due to PR-6245 #7102

linhua11 opened this issue Aug 1, 2024 · 3 comments · May be fixed by #7383
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider kind/bug Categorizes issue or PR as related to a bug.

Comments

@linhua11
Copy link

linhua11 commented Aug 1, 2024

Which component are you using?: cluster-autoscaler

What version of the component are you using?: 1.29.2 and 1.29.4

Component version:

What k8s version are you using (kubectl version)?: 1.29

kubectl version Output
$ kubectl version

What environment is this in?: AWS

What did you expect to happen?: No increased AWS API call due to rate limit issue

What happened instead?: Due to PR-6245, even if we don't use MixedInstancesPolicy.instanceRequirements since we use balacing-label and having active nodes. It still calls DescribeLaunchTemplateVersions which pushes the CA to have some rate limiting issue. And there is no way to disable this feature

How to reproduce it (as minimally and precisely as possible):
Just start a CA with balancing labels like
- --balancing-label=xxxxx
- --expander=least-waste
- --aws-use-static-instance-list=true
Compare the number of aws api calls between version 1.27.6 and 1.27.7, you will find increased API calls

Anything else we need to know?:

@linhua11 linhua11 added the kind/bug Categorizes issue or PR as related to a bug. label Aug 1, 2024
@Shubham82
Copy link
Contributor

/area provider/aws
/area cluster-autoscaler

Here is the PR that is mentioned in the issue description: #6245

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider area/cluster-autoscaler labels Aug 1, 2024
@rrangith rrangith linked a pull request Oct 11, 2024 that will close this issue
@rrangith
Copy link
Contributor

hi @linhua11 i opened #7383 which should fix this issue

@linhua11
Copy link
Author

@rrangith thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants