Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new taint key in design doc #985

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Use new taint key in design doc #985

merged 1 commit into from
Nov 21, 2017

Conversation

resouer
Copy link
Contributor

@resouer resouer commented Aug 24, 2017 •
edited
Loading

Part of: kubernetes/kubernetes#51246

DO NOT MERGE until kubernetes/kubernetes#51266 is in!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2017
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 24, 2017
@thockin thockin assigned davidopp and unassigned thockin Aug 24, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2017
@resouer resouer closed this Oct 18, 2017
@resouer resouer reopened this Oct 19, 2017
@resouer resouer mentioned this pull request Oct 19, 2017
Closed
12 tasks
@resouer
Copy link
Contributor Author

resouer commented Oct 19, 2017

cc @k82cn for review

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2017
k82cn
k82cn reviewed Oct 19, 2017
View reviewed changes
contributors/design-proposals/scheduling/taint-node-by-condition.md Outdated
| |Unknown | NoExecute | node.kubernetes.io/unreachable |
|OutOfDisk |True | NoSchedule | node.kubernetes.io/outOfDisk |
| |False | NoExecute | node.kubernetes.io/not-ready |
| |Unknown | NoExecute | node.alpha.kubernetes.io/unreachable |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not also remove alpha for unreachable? so we will handle not-ready and unreachable in the same way :).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should, bad rebase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fired up kubernetes/kubernetes#54198 to track this inconsistency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great！

@k82cn
Copy link
Member

k82cn commented Oct 19, 2017

/lgtm , just can not remember why we only change not-ready :).

@resouer
Copy link
Contributor Author

resouer commented Oct 19, 2017

Addressed comments.

just can not remember why we only change not-ready :).

Not clear for me either ...

@resouer resouer mentioned this pull request Oct 19, 2017
Closed
2 tasks
@k8s-github-robot k8s-github-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Oct 27, 2017
@k8s-github-robot
Copy link

This PR hasn't been active in 30 days. It will be closed in 59 days (Jan 17, 2018).

cc @brendandburns @davidopp @k82cn @resouer

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

@davidopp
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2017
@resouer
Copy link
Contributor Author

resouer commented Nov 21, 2017

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@resouer
Copy link
Contributor Author

resouer commented Nov 21, 2017

@davidopp thanks, merge?

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 0b054be into kubernetes:master Nov 21, 2017
@resouer resouer deleted the fix-taint-key branch November 21, 2017 12:40
@resouer
Copy link
Contributor Author

resouer commented Nov 21, 2017

OK. The bot is clever than I expect :)

@fejta fejta added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. keep-open labels Dec 15, 2017
MadhavJivrajani pushed a commit to MadhavJivrajani/community that referenced this pull request Nov 30, 2021
Merge pull request kubernetes#985 from resouer/fix-taint-key
32da2e3 
Automatic merge from submit-queue.

Use new taint key in design doc

Part of: kubernetes/kubernetes#51246

~~**DO NOT MERGE** until kubernetes/kubernetes#51266 is in!~~
danehans pushed a commit to danehans/community that referenced this pull request Jul 18, 2023
@istio-testing
Automator: update common-files@master in istio/community@master (kube…
e32caac 
…rnetes#985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

Assignees

@brendandburns brendandburns

@davidopp davidopp

@k82cn k82cn

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@resouer @k82cn @k8s-github-robot @davidopp @fejta @thockin @brendandburns @k8s-ci-robot