This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Ubernetes multizone and custom healthchecks #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -201,18 +197,31 @@ func (b *Backends) List() ([]interface{}, error) { | |||
| return interList, nil | |||
| } | |||
|
|
|||
| func getBackendsForIGs(igs []*compute.InstanceGroup) []*compute.Backend { | |||
There was a problem hiding this comment.
just curious. If not all ubernetes clusters are on gce, how do you handle it? Or just does not support this case?
Can GCE L7 support compute backends which are not on gce?
There was a problem hiding this comment.
nope, this is only "ubernetes-lite" i.e ubernetes deployment multi-az in gce.
|
mostly nits. Feel free to update and self LGTM. |
bprashanth
force-pushed
the
ubernetes_healthchecks
branch
from
0a55071
to
06674d3
Compare
|
Updated nits, merging |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Jun 17, 2016
Automatic merge from submit-queue Extend ingress e2e Splits the test into a cross platform conformance list, and platform specific bits that exercise features through annotations. Also exercises the features in kubernetes-retired/contrib#1133. Assigning to Girish, simply because I assigned the other pr to Minhan.
aledbf
pushed a commit
to aledbf/contrib
that referenced
this pull request
Nov 10, 2016
…healthchecks Ubernetes multizone and custom healthchecks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kubernetes/goog-cluster fyi
Fixes #983 and #953