Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Update Ingress godep #1247

Merged
merged 4 commits into from
Jun 21, 2016
Merged

Update Ingress godep #1247

merged 4 commits into from
Jun 21, 2016

Conversation

bprashanth
Copy link

@aledbf fyi

@zmerlynn
Copy link
Contributor

LGTM.

Out of curiosity, can this tag be used for release-1.2 as well, or is there an incompatibility there?

@bprashanth
Copy link
Author

It can, I'm not sure how I'm going to handle the 1.2 update. We don't really "release" cluster addons, the l7 controller runs on the master so it should just rev forward automatically on hosted offerings. If someone sets up a new cluster (with old 1.2 code) on gce/prem etc, they'll get an old l7. They can use kubectl edit to update the image on this old controller forward to 0.7.0.

It should be safe to just update this tag to 1.2 because the resource didn't change, but I need to test it some more.

@bprashanth
Copy link
Author

We don't really "release" cluster addons, the l7 controller runs on the master so it should just rev forward automatically on hosted offerings.

I meant we don't branch, we release eg: https://github.com/kubernetes/contrib/releases, no reason we can't other than it's in beta so it's still in contrib/

@zmerlynn
Copy link
Contributor

We're about to cut a 1.2.5. If you get the PR into master for bumping kubernetes/kubernetes/cluster/saltbase/salt/l7-gcp/glbc.manifest, we can get it cherry-picked to release-1.2, and it'll go out when we update hosted masters in GKE.

@zmerlynn zmerlynn added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2016
@zmerlynn
Copy link
Contributor

Does this Travis ever work?

@zmerlynn
Copy link
Contributor

(Feel free to merge if not.)

@bprashanth
Copy link
Author

Yeah I think it broke maybe because of some change, looking. Thanks for lgtm will merge when i fix. I think we wouldn't have the famed "green badge" if it didn't work: https://github.com/kubernetes/contrib

@bprashanth
Copy link
Author

Green, merging

@bprashanth bprashanth merged commit 413b7dc into kubernetes-retired:master Jun 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants