This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Allocate and remember cluster uid #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
bprashanth
changed the title
bprashanth
force-pushed
the
cluster_uid
branch
3 times, most recently
from
2b7dbaa
to
b3ee5fe
Compare
bprashanth
changed the title
|
LGTM |
|
Thanks! |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
May 31, 2016
Automatic merge from submit-queue Run l7 controller on master Fixes #23663, needs kubernetes-retired/contrib#680 @roberthbailey @kubernetes/goog-cluster
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remembers existing cluster uids in a config map so even if it changes we don't delete/re-create working loadbalancers. This means once a cluster is up and running with a uid, it doesn't change no matter how many time the controller is restarted with a different uid, unless someone deletes the uid config map in kube-system.
This is needed so we can rollout a change that auto-assigns uids to controllers, which in turn is required before we start running the controller on the master.