Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logs icons to a menu #3766

Merged
merged 5 commits into from
May 30, 2019
Merged

Conversation

feloy
Copy link
Member

@feloy feloy commented Apr 27, 2019

Here is my proposition to fix the issue #3754.

In the logs view, the toggle buttons are instead placed in a floating menu.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2019
@codecov
Copy link

codecov bot commented Apr 27, 2019

Codecov Report

Merging #3766 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3766   +/-   ##
=======================================
  Coverage   47.14%   47.14%           
=======================================
  Files         171      171           
  Lines        7971     7971           
  Branches       62       62           
=======================================
  Hits         3758     3758           
  Misses       3972     3972           
  Partials      241      241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0420e4...b7c2965. Read the comment docs.

@jeefy
Copy link
Member

jeefy commented Apr 28, 2019

This looks awesome and I love the direction.

Couple small thoughts:

  • Whenever you click inside the menu popup (anywhere, not just a checkbox), the menu closes.
  • Also, whenever you click the text associated with a checkbox, said checkbox doesn't get checked.

If you can address those two behaviors this should get merged in quick.

/assign

@jeefy
Copy link
Member

jeefy commented May 1, 2019

@feloy There are some formatting nits that are causing the Travis job to fail.

Please run npm run check locally before committing/pushing. This should show these formatting issues ahead of time. :) Let me know if you have any questions.

When these nits get fixed this looks good to merge!

@maciaszczykm
Copy link
Member

Please rebase/merge master to fix the issues with the CI job. Sorry for the inconvenience.

@jeefy
Copy link
Member

jeefy commented May 12, 2019

@feloy There's one more conflict that needs resolving. Everything else lgtm so hoping to merge this soon.

Thanks!

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2019
@jeefy
Copy link
Member

jeefy commented May 29, 2019

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2019
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy, jeefy, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants