From 1b5e22ed098477f8ab618b27d7f0196dc6c496b4 Mon Sep 17 00:00:00 2001 From: Andrew Sy Kim Date: Thu, 2 Feb 2023 10:14:51 -0500 Subject: [PATCH] kep-1669: add GA graduation criterias for v1.27 Signed-off-by: Andrew Sy Kim --- keps/prod-readiness/sig-network/1669.yaml | 2 ++ .../sig-network/1669-proxy-terminating-endpoints/README.md | 7 +++++++ keps/sig-network/1669-proxy-terminating-endpoints/kep.yaml | 7 ++++--- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/keps/prod-readiness/sig-network/1669.yaml b/keps/prod-readiness/sig-network/1669.yaml index 5b4debe4032..6d9dfae99e1 100644 --- a/keps/prod-readiness/sig-network/1669.yaml +++ b/keps/prod-readiness/sig-network/1669.yaml @@ -3,3 +3,5 @@ alpha: approver: "@wojtek-t" beta: approver: "@wojtek-t" +stable: + approver: "@wojtek-t" diff --git a/keps/sig-network/1669-proxy-terminating-endpoints/README.md b/keps/sig-network/1669-proxy-terminating-endpoints/README.md index 7bb631bc970..e05233de9a5 100644 --- a/keps/sig-network/1669-proxy-terminating-endpoints/README.md +++ b/keps/sig-network/1669-proxy-terminating-endpoints/README.md @@ -26,6 +26,7 @@ - [Graduation Criteria](#graduation-criteria) - [Alpha](#alpha) - [Beta](#beta) + - [GA](#ga) - [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy) - [Version Skew Strategy](#version-skew-strategy) - [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire) @@ -190,6 +191,7 @@ and internalTrafficPolicy. - E2E test validating fallback behavior for terminating endpoints when `externalTrafficPolicy: Local`: https://github.com/kubernetes/kubernetes/blob/4bc1398c0834a63370952702eef24d5e74c736f6/test/e2e/network/service.go#L3145 - E2E test validating fallback behaviro for terminating endpoints when `internalTrafficPolicy: Cluster`: https://github.com/kubernetes/kubernetes/blob/4bc1398c0834a63370952702eef24d5e74c736f6/test/e2e/network/service.go#L2889 - E2E test validating fallback behaviro for terminating endpoints when `internalTrafficPolicy: Local`: https://github.com/kubernetes/kubernetes/blob/4bc1398c0834a63370952702eef24d5e74c736f6/test/e2e/network/service.go#L2972 +- E2E test performing rolling update with an LB using `externalTrafficiPolicy: Local`: https://github.com/kubernetes/kubernetes/blob/f333e5b4c5a174c63ac8e71f2c187f434ce56b1b/test/e2e/network/loadbalancer.go#L1283-L1299 ### Graduation Criteria @@ -206,6 +208,11 @@ and internalTrafficPolicy. * Metrics to publish how many Services/Endpoints are routing traffic to terminating endpoints. * Manual or automated rollback testing (see [Test Plan](#test-plan) section) +#### GA + +* Feedback from users in issue [85643](https://github.com/kubernetes/kubernetes/issues/85643) that enabling ProxyTerminatingEndpoints can achieve zero downtime rolling updates when using `externalTrafficPolicy: Local` +* E2E tests demonstrating that rolling updates can be performed with negligible downtime (ideally 100%, but may not feasible without flakiness) with a Service LoadBalancer when using externalTrafficPolicy: Local + ### Upgrade / Downgrade Strategy Behavioral changes to terminating endpoints will apply when the feature gate is enabled. It is required that the cluster has the EndpointSlice API enabled and diff --git a/keps/sig-network/1669-proxy-terminating-endpoints/kep.yaml b/keps/sig-network/1669-proxy-terminating-endpoints/kep.yaml index d8600f3b79b..c3bebcc452d 100644 --- a/keps/sig-network/1669-proxy-terminating-endpoints/kep.yaml +++ b/keps/sig-network/1669-proxy-terminating-endpoints/kep.yaml @@ -12,24 +12,25 @@ reviewers: approvers: - "@thockin" creation-date: 2020-04-07 -last-updated: 2022-01-21 +last-updated: 2023-02-02 status: implementable see-also: - "/keps/sig-network/1672-tracking-terminating-endpoints/README.md" - https://github.com/kubernetes/kubernetes/issues/85643 # The target maturity stage in the current dev cycle for this KEP. -stage: beta +stage: stable # The most recent milestone for which work toward delivery of this KEP has been # done. This can be the current (upcoming) milestone, if it is being actively # worked on. -latest-milestone: "v1.26" +latest-milestone: "v1.27" # The milestone at which this feature was, or is targeted to be, at each stage. milestone: alpha: "v1.22" beta: "v1.26" + stable: "v1.27" # The following PRR answers are required at alpha release # List the feature gate name and the components for which it must be enabled