From c48b0334b8413655a633c36dd3bec97ba35f0305 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Fri, 8 Oct 2021 08:33:03 -0700 Subject: [PATCH 01/12] pkg/kepval: require prr check for implemented keps Tests will fail at this commit, subsequent commits update data to resolve the failures. --- pkg/kepval/approval.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kepval/approval.go b/pkg/kepval/approval.go index ad1eaed26c6..8b66d823946 100644 --- a/pkg/kepval/approval.go +++ b/pkg/kepval/approval.go @@ -100,7 +100,7 @@ func ValidatePRR(kep *api.Proposal, h *api.PRRHandler, prrDir string) error { func isPRRRequired(kep *api.Proposal) (required, missingMilestone, missingStage bool, err error) { logrus.Debug("checking if PRR is required") - required = kep.Status == api.ImplementableStatus + required = kep.Status == api.ImplementableStatus || kep.Status == api.ImplementedStatus missingMilestone = kep.IsMissingMilestone() missingStage = kep.IsMissingStage() From ed17414ed09e117b33f8407517e2a69fa839452e Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Fri, 8 Oct 2021 09:05:22 -0700 Subject: [PATCH 02/12] hack: add edit-keps.py helper script to edit keps en-masse, hardcoded in this case to make a guess at stage and latest-milestone for keps with status: implemented ./hack/edit-keps.py --keps-dir ./keps --- hack/edit-keps.py | 103 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 103 insertions(+) create mode 100755 hack/edit-keps.py diff --git a/hack/edit-keps.py b/hack/edit-keps.py new file mode 100755 index 00000000000..3c6b3fc7770 --- /dev/null +++ b/hack/edit-keps.py @@ -0,0 +1,103 @@ +#!/usr/bin/env python3 + +# Copyright 2021 The Kubernetes Authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +"""Edit KEPs en-masse by round-tripping them through ruamel.yaml + +This is not intended for general usage, because: +- many keps have different formatting, and we're not at a point where + we can enforce formatting standards, so this is almost guaranteed + to introduce formatting change noise +- the idea is to manually edit this file with the specific edit to be + done, rather that developing a general purpose language to do this +""" + +import argparse +import glob + +from os import path + +import ruamel.yaml + +# Files that will be ignored +EXCLUDED_FILES = [] +# A hilariously large line length to ensure we never line-wrap +MAX_WIDTH = 2000000000 + +def setup_yaml(): + # Setup the ruamel.yaml parser + yaml = ruamel.yaml.YAML(typ='rt') + yaml.preserve_quotes = True + # This is what's used in the template, currently ~36 KEPs have drifted + yaml.indent(mapping=2, sequence=4, offset=2) + yaml.width = MAX_WIDTH + return yaml + +def edit_kep(yaml, file_name, force_rewrite=False): + with open(file_name, "r") as fp: + kep = yaml.load(fp) + + rewrite = force_rewrite + + stage = kep.get("stage", "unknown") + status = kep.get("status", "unknown") + latest_milestone = kep.get("latest-milestone", "unknown") + last_updated = kep.get("last-updated", "unknown") + milestone = kep.get("milestone", {}) + + if status == "implemented": + if latest_milestone == "unknown": + print(f'status: {status} stage: {stage} last-updated: {last_updated} file: {file_name}') + kep["latest-milestone"] = "0.0" + rewrite = True + if stage == "unknown": + if latest_milestone == "unknown": + kep["stage"] = "stable" + else: + kep["stage"] = [s for s,v in milestone.items() if v == latest_milestone][0] + rewrite = True + + # Dump KEP to file_name + if rewrite: + print(f' writing {file_name}') + with open(file_name, "w") as fp: + yaml.dump(kep, fp) + fp.truncate() + +def main(keps_dir, force_rewrite): + yaml = setup_yaml() + for f in glob.glob(f'{keps_dir}/**/kep.yaml', recursive=True): + if path.basename(f) not in EXCLUDED_FILES: + try: + print(f'processing file: {f}') + edit_kep(yaml, f, force_rewrite) + except Exception as e: # pylint: disable=broad-except + print(f'ERROR: could not edit {f}: {e}') + +if __name__ == '__main__': + PARSER = argparse.ArgumentParser( + description='Does things to KEPs') + PARSER.add_argument( + '--keps-dir', + default='../keps', + help='Path to KEPs directoryProw Job Directory') + PARSER.add_argument( + '--force', + default=False, + help='Force rewrite of all KEPs') + ARGS = PARSER.parse_args() + + main(ARGS.keps_dir, ARGS.force) + From 761668f82fef6727d2cbee10e632c371dfded529 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Fri, 8 Oct 2021 10:14:38 -0700 Subject: [PATCH 03/12] keps: add latest-milestone and stage to implemented KEPs Added via hack/edit-keps.py --- .../1152-less-object-serializations/kep.yaml | 2 ++ .../1623-standardize-conditions/kep.yaml | 2 ++ .../2332-pruning-for-custom-resources/kep.yaml | 2 ++ .../kep.yaml | 2 ++ .../2337-k8s.io-group-protection/kep.yaml | 2 ++ keps/sig-api-machinery/492-admission-webhooks/kep.yaml | 2 ++ keps/sig-api-machinery/575-crd-defaulting/kep.yaml | 2 ++ keps/sig-api-machinery/576-dry-run/kep.yaml | 2 ++ .../598-crd-conversion-webhook/kep.yaml | 2 ++ keps/sig-api-machinery/956-watch-bookmark/kep.yaml | 2 ++ keps/sig-architecture/0000-kep-process/kep.yaml | 2 ++ keps/sig-architecture/1194-prod-readiness/kep.yaml | 2 ++ keps/sig-architecture/1635-prevent-permabeta/kep.yaml | 1 + .../1659-standard-topology-labels/kep.yaml | 1 + .../sig-auth/1513-certificate-signing-request/kep.yaml | 2 ++ .../1687-hierarchical-namespaces-subproject/kep.yaml | 2 ++ .../kep.yaml | 1 + keps/sig-auth/279-limit-node-access/kep.yaml | 2 ++ .../789-harden-default-discover-bindings/kep.yaml | 2 ++ .../117-hpa-metrics-specificity/kep.yaml | 2 ++ .../853-configurable-hpa-scale-velocity/kep.yaml | 2 ++ keps/sig-cli/2377-Kustomize/kep.yaml | 2 ++ keps/sig-cli/2379-kubectl-plugins/kep.yaml | 2 ++ .../kep.yaml | 2 ++ .../2386-kustomize-subcommand-integration/kep.yaml | 2 ++ keps/sig-cli/491-kubectl-diff/kep.yaml | 2 ++ .../1179-building-without-in-tree-providers/kep.yaml | 2 ++ .../669-out-of-tree-openstack/kep.yaml | 2 ++ .../670-out-of-tree-vsphere/kep.yaml | 2 ++ .../azure/2328-ccm-instance-metadata/kep.yaml | 2 ++ .../kubeadm/378-bootstrap-checkpointing/kep.yaml | 2 ++ .../0000-community-forum/kep.yaml | 2 ++ .../1553-issue-triage/kep.yaml | 2 ++ .../2225-contributor-site/kep.yaml | 2 ++ .../sig-instrumentation/1206-metrics-overhaul/kep.yaml | 2 ++ keps/sig-network/1024-nodelocal-cache-dns/kep.yaml | 2 ++ .../kep.yaml | 2 ++ .../kep.yaml | 2 ++ .../kep.yaml | 2 ++ .../kep.yaml | 2 ++ .../sig-network/265-ipvs-based-load-balancing/kep.yaml | 2 ++ keps/sig-network/980-load-balancer-finalizers/kep.yaml | 2 ++ keps/sig-node/135-seccomp/kep.yaml | 2 ++ .../1547-building-kubelet-without-docker/kep.yaml | 2 ++ keps/sig-node/166-taint-based-eviction/kep.yaml | 2 ++ keps/sig-node/495-pod-pid-namespace/kep.yaml | 10 ++++++---- keps/sig-node/589-efficient-node-heartbeats/kep.yaml | 2 ++ keps/sig-node/757-pid-limiting/kep.yaml | 2 ++ keps/sig-node/950-liveness-probe-holdoff/kep.yaml | 2 ++ keps/sig-release/1733-release-notes/kep.yaml | 2 ++ .../382-taint-node-by-condition/kep.yaml | 2 ++ .../548-schedule-daemonset-pods/kep.yaml | 2 ++ .../986-resource-quota-scope-selectors/kep.yaml | 2 ++ keps/sig-storage/121-local-persistent-volumes/kep.yaml | 2 ++ .../1900-volume-snapshot-validation-webhook/kep.yaml | 1 + keps/sig-storage/351-raw-block-support/kep.yaml | 2 ++ keps/sig-storage/554-maximum-volume-count/kep.yaml | 2 ++ keps/sig-storage/557-csi-topology/kep.yaml | 2 ++ keps/sig-storage/559-volume-subpath-expansion/kep.yaml | 2 ++ keps/sig-storage/565-csi-block-support/kep.yaml | 2 ++ keps/sig-storage/603-csi-pod-info/kep.yaml | 2 ++ keps/sig-storage/770-csi-skip-attach/kep.yaml | 2 ++ keps/sig-storage/989-extend-datasource/kep.yaml | 2 ++ .../sig-windows/1043-windows-security-context/kep.yaml | 2 ++ keps/sig-windows/116-windows-node-support/kep.yaml | 2 ++ keps/sig-windows/689-windows-gmsa/kep.yaml | 2 ++ 66 files changed, 132 insertions(+), 4 deletions(-) diff --git a/keps/sig-api-machinery/1152-less-object-serializations/kep.yaml b/keps/sig-api-machinery/1152-less-object-serializations/kep.yaml index 28beda985e7..85d0546466d 100644 --- a/keps/sig-api-machinery/1152-less-object-serializations/kep.yaml +++ b/keps/sig-api-machinery/1152-less-object-serializations/kep.yaml @@ -21,3 +21,5 @@ replaces: - n/a superseded-by: - n/a +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-api-machinery/1623-standardize-conditions/kep.yaml b/keps/sig-api-machinery/1623-standardize-conditions/kep.yaml index 02f67cf2fe8..6cf50141fb0 100644 --- a/keps/sig-api-machinery/1623-standardize-conditions/kep.yaml +++ b/keps/sig-api-machinery/1623-standardize-conditions/kep.yaml @@ -17,3 +17,5 @@ approvers: - "@liggitt" see-also: replaces: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-api-machinery/2332-pruning-for-custom-resources/kep.yaml b/keps/sig-api-machinery/2332-pruning-for-custom-resources/kep.yaml index 99f1992aa2a..588afbf8bfe 100644 --- a/keps/sig-api-machinery/2332-pruning-for-custom-resources/kep.yaml +++ b/keps/sig-api-machinery/2332-pruning-for-custom-resources/kep.yaml @@ -22,3 +22,5 @@ status: implemented see-also: - "https://github.com/kubernetes/enhancements/pull/1002" - "/keps/sig-api-machinery/20180415-crds-to-ga.md" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-api-machinery/2335-vanilla-crd-openapi-subset-structural-schemas/kep.yaml b/keps/sig-api-machinery/2335-vanilla-crd-openapi-subset-structural-schemas/kep.yaml index 0547f06026a..e40b300a97c 100644 --- a/keps/sig-api-machinery/2335-vanilla-crd-openapi-subset-structural-schemas/kep.yaml +++ b/keps/sig-api-machinery/2335-vanilla-crd-openapi-subset-structural-schemas/kep.yaml @@ -22,3 +22,5 @@ see-also: - "/keps/sig-api-machinery/20180415-crds-to-ga.md" - "https://github.com/kubernetes/enhancements/pull/926" - "https://github.com/kubernetes/enhancements/pull/709" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-api-machinery/2337-k8s.io-group-protection/kep.yaml b/keps/sig-api-machinery/2337-k8s.io-group-protection/kep.yaml index abd38027156..0d5dc597d15 100644 --- a/keps/sig-api-machinery/2337-k8s.io-group-protection/kep.yaml +++ b/keps/sig-api-machinery/2337-k8s.io-group-protection/kep.yaml @@ -17,3 +17,5 @@ editor: "@deads2k" creation-date: 2019-06-12 last-updated: 2019-07-03 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-api-machinery/492-admission-webhooks/kep.yaml b/keps/sig-api-machinery/492-admission-webhooks/kep.yaml index 1cc80d02c92..cad74d29c92 100644 --- a/keps/sig-api-machinery/492-admission-webhooks/kep.yaml +++ b/keps/sig-api-machinery/492-admission-webhooks/kep.yaml @@ -15,3 +15,5 @@ last-updated: 2019-02-04 status: implemented see-also: - "[Admission Control Webhook Beta Design Doc](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/admission-control-webhooks.md)" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-api-machinery/575-crd-defaulting/kep.yaml b/keps/sig-api-machinery/575-crd-defaulting/kep.yaml index 1887e90ec1e..630813525ea 100644 --- a/keps/sig-api-machinery/575-crd-defaulting/kep.yaml +++ b/keps/sig-api-machinery/575-crd-defaulting/kep.yaml @@ -21,3 +21,5 @@ status: implemented see-also: - "/keps/sig-api-machinery/20180731-crd-pruning.md" - "/keps/sig-api-machinery/20190425-structural-openapi.md" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-api-machinery/576-dry-run/kep.yaml b/keps/sig-api-machinery/576-dry-run/kep.yaml index 2df4431b41d..ab78a5955a2 100644 --- a/keps/sig-api-machinery/576-dry-run/kep.yaml +++ b/keps/sig-api-machinery/576-dry-run/kep.yaml @@ -15,3 +15,5 @@ editor: apelisse creation-date: 2018-06-21 last-updated: 2020-03-23 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-api-machinery/598-crd-conversion-webhook/kep.yaml b/keps/sig-api-machinery/598-crd-conversion-webhook/kep.yaml index 13ca509ca6e..e8c514b05c4 100644 --- a/keps/sig-api-machinery/598-crd-conversion-webhook/kep.yaml +++ b/keps/sig-api-machinery/598-crd-conversion-webhook/kep.yaml @@ -18,3 +18,5 @@ last-updated: 2019-04-25 status: implemented replaces: - "(https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/customresource-conversion-webhook.md)" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-api-machinery/956-watch-bookmark/kep.yaml b/keps/sig-api-machinery/956-watch-bookmark/kep.yaml index e0d349fae7d..3044e0bbabb 100644 --- a/keps/sig-api-machinery/956-watch-bookmark/kep.yaml +++ b/keps/sig-api-machinery/956-watch-bookmark/kep.yaml @@ -19,3 +19,5 @@ replaces: - n/a superseded-by: - n/a +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-architecture/0000-kep-process/kep.yaml b/keps/sig-architecture/0000-kep-process/kep.yaml index a6b10f2bcc3..138366e58e6 100644 --- a/keps/sig-architecture/0000-kep-process/kep.yaml +++ b/keps/sig-architecture/0000-kep-process/kep.yaml @@ -12,3 +12,5 @@ editor: "@jbeda" creation-date: 2017-08-22 last-updated: 2020-02-18 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-architecture/1194-prod-readiness/kep.yaml b/keps/sig-architecture/1194-prod-readiness/kep.yaml index cc0745dae4a..1bf3001daa5 100644 --- a/keps/sig-architecture/1194-prod-readiness/kep.yaml +++ b/keps/sig-architecture/1194-prod-readiness/kep.yaml @@ -18,3 +18,5 @@ approvers: creation-date: 2019-07-31 last-updated: 2020-12-15 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-architecture/1635-prevent-permabeta/kep.yaml b/keps/sig-architecture/1635-prevent-permabeta/kep.yaml index 85ae671a014..463707a20aa 100644 --- a/keps/sig-architecture/1635-prevent-permabeta/kep.yaml +++ b/keps/sig-architecture/1635-prevent-permabeta/kep.yaml @@ -28,3 +28,4 @@ approvers: - "@johnbelamaric" see-also: replaces: +stage: stable diff --git a/keps/sig-architecture/1659-standard-topology-labels/kep.yaml b/keps/sig-architecture/1659-standard-topology-labels/kep.yaml index a551c52f4e4..56a011c0c68 100644 --- a/keps/sig-architecture/1659-standard-topology-labels/kep.yaml +++ b/keps/sig-architecture/1659-standard-topology-labels/kep.yaml @@ -22,3 +22,4 @@ stage: stable feature-gates: [] disable-supported: false metrics: [] +latest-milestone: '0.0' diff --git a/keps/sig-auth/1513-certificate-signing-request/kep.yaml b/keps/sig-auth/1513-certificate-signing-request/kep.yaml index 7dd73fd9763..b9f473103dd 100644 --- a/keps/sig-auth/1513-certificate-signing-request/kep.yaml +++ b/keps/sig-auth/1513-certificate-signing-request/kep.yaml @@ -14,3 +14,5 @@ approvers: creation-date: 2019-06-07 last-updated: 2020-09-14 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-auth/1687-hierarchical-namespaces-subproject/kep.yaml b/keps/sig-auth/1687-hierarchical-namespaces-subproject/kep.yaml index cc8ecef4059..b5fea9348c2 100644 --- a/keps/sig-auth/1687-hierarchical-namespaces-subproject/kep.yaml +++ b/keps/sig-auth/1687-hierarchical-namespaces-subproject/kep.yaml @@ -16,3 +16,5 @@ approvers: creation-date: 2020-04-14 last-updated: 2021-01-06 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-auth/266-kubelet-client-certificate-bootstrap-rotation/kep.yaml b/keps/sig-auth/266-kubelet-client-certificate-bootstrap-rotation/kep.yaml index 0b0a0135b5a..83b3a1ca0f1 100644 --- a/keps/sig-auth/266-kubelet-client-certificate-bootstrap-rotation/kep.yaml +++ b/keps/sig-auth/266-kubelet-client-certificate-bootstrap-rotation/kep.yaml @@ -33,3 +33,4 @@ disable-supported: true metrics: - kubelet_certificate_manager_client_expiration_seconds - kubelet_certificate_manager_client_expiration_renew_errors +stage: stable diff --git a/keps/sig-auth/279-limit-node-access/kep.yaml b/keps/sig-auth/279-limit-node-access/kep.yaml index 4c194adbc26..6b3f1a2c2b9 100644 --- a/keps/sig-auth/279-limit-node-access/kep.yaml +++ b/keps/sig-auth/279-limit-node-access/kep.yaml @@ -16,3 +16,5 @@ approvers: creation-date: 2017-08-14 last-updated: 2020-05-01 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-auth/789-harden-default-discover-bindings/kep.yaml b/keps/sig-auth/789-harden-default-discover-bindings/kep.yaml index d8cacc41f9e..17a5d89bbc8 100644 --- a/keps/sig-auth/789-harden-default-discover-bindings/kep.yaml +++ b/keps/sig-auth/789-harden-default-discover-bindings/kep.yaml @@ -18,3 +18,5 @@ editor: TBD creation-date: 2019-01-28 last-updated: 2019-01-31 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-autoscaling/117-hpa-metrics-specificity/kep.yaml b/keps/sig-autoscaling/117-hpa-metrics-specificity/kep.yaml index 6d1f38c13fb..0bf741cd6e7 100644 --- a/keps/sig-autoscaling/117-hpa-metrics-specificity/kep.yaml +++ b/keps/sig-autoscaling/117-hpa-metrics-specificity/kep.yaml @@ -16,3 +16,5 @@ editor: "@directxman12" creation-date: 2018-04-19 last-updated: 2018-04-19 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-autoscaling/853-configurable-hpa-scale-velocity/kep.yaml b/keps/sig-autoscaling/853-configurable-hpa-scale-velocity/kep.yaml index bcf753a642c..5e6ac5a67b6 100644 --- a/keps/sig-autoscaling/853-configurable-hpa-scale-velocity/kep.yaml +++ b/keps/sig-autoscaling/853-configurable-hpa-scale-velocity/kep.yaml @@ -16,3 +16,5 @@ creation-date: 2019-03-07 last-updated: 2020-01-29 status: implemented superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-cli/2377-Kustomize/kep.yaml b/keps/sig-cli/2377-Kustomize/kep.yaml index ad46747764e..20988e81783 100644 --- a/keps/sig-cli/2377-Kustomize/kep.yaml +++ b/keps/sig-cli/2377-Kustomize/kep.yaml @@ -20,3 +20,5 @@ replaces: - kinflate # Old name for kustomize superseded-by: - "/keps/sig-cli/2386-kustomize-subcommand-integration/" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-cli/2379-kubectl-plugins/kep.yaml b/keps/sig-cli/2379-kubectl-plugins/kep.yaml index 7b8ee20325e..34381e0eea5 100644 --- a/keps/sig-cli/2379-kubectl-plugins/kep.yaml +++ b/keps/sig-cli/2379-kubectl-plugins/kep.yaml @@ -24,3 +24,5 @@ replaces: - "https://github.com/kubernetes/community/pull/481" superseded-by: - n/a +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-cli/2384-kustomize-file-processing-integration/kep.yaml b/keps/sig-cli/2384-kustomize-file-processing-integration/kep.yaml index ef41765e18d..95a8c812b20 100644 --- a/keps/sig-cli/2384-kustomize-file-processing-integration/kep.yaml +++ b/keps/sig-cli/2384-kustomize-file-processing-integration/kep.yaml @@ -24,3 +24,5 @@ see-also: replaces: superseded-by: - n/a +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-cli/2386-kustomize-subcommand-integration/kep.yaml b/keps/sig-cli/2386-kustomize-subcommand-integration/kep.yaml index f8bf17026ab..ec80abb8aea 100644 --- a/keps/sig-cli/2386-kustomize-subcommand-integration/kep.yaml +++ b/keps/sig-cli/2386-kustomize-subcommand-integration/kep.yaml @@ -24,3 +24,5 @@ replaces: - "0008-kustomize.md" superseded-by: - n/a +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-cli/491-kubectl-diff/kep.yaml b/keps/sig-cli/491-kubectl-diff/kep.yaml index 9e4229ba300..c8ed1ad6588 100644 --- a/keps/sig-cli/491-kubectl-diff/kep.yaml +++ b/keps/sig-cli/491-kubectl-diff/kep.yaml @@ -17,3 +17,5 @@ status: implemented see-also: - "/keps/sig-api-machinery/0015-dry-run.md" - "/keps/sig-api-machinery/0006-apply.md" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-cloud-provider/1179-building-without-in-tree-providers/kep.yaml b/keps/sig-cloud-provider/1179-building-without-in-tree-providers/kep.yaml index c18f08ef935..36480018ffc 100644 --- a/keps/sig-cloud-provider/1179-building-without-in-tree-providers/kep.yaml +++ b/keps/sig-cloud-provider/1179-building-without-in-tree-providers/kep.yaml @@ -23,3 +23,5 @@ status: implemented see-also: - "/keps/sig-cloud-provider/20190125-removing-in-tree-providers.md" - "/keps/sig-cloud-provider/20180530-cloud-controller-manager.md" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-cloud-provider/669-out-of-tree-openstack/kep.yaml b/keps/sig-cloud-provider/669-out-of-tree-openstack/kep.yaml index 39b3a95d3fd..10def15d073 100644 --- a/keps/sig-cloud-provider/669-out-of-tree-openstack/kep.yaml +++ b/keps/sig-cloud-provider/669-out-of-tree-openstack/kep.yaml @@ -15,3 +15,5 @@ editor: TBD creation-date: 2019-01-25 last-updated: 2019-01-25 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-cloud-provider/670-out-of-tree-vsphere/kep.yaml b/keps/sig-cloud-provider/670-out-of-tree-vsphere/kep.yaml index c9bdf8e794c..27ddb596aba 100644 --- a/keps/sig-cloud-provider/670-out-of-tree-vsphere/kep.yaml +++ b/keps/sig-cloud-provider/670-out-of-tree-vsphere/kep.yaml @@ -18,3 +18,5 @@ editor: TBD creation-date: 2019-01-25 last-updated: 2020-04-09 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-cloud-provider/azure/2328-ccm-instance-metadata/kep.yaml b/keps/sig-cloud-provider/azure/2328-ccm-instance-metadata/kep.yaml index 90f038667ed..19b5638e700 100644 --- a/keps/sig-cloud-provider/azure/2328-ccm-instance-metadata/kep.yaml +++ b/keps/sig-cloud-provider/azure/2328-ccm-instance-metadata/kep.yaml @@ -13,3 +13,5 @@ creation-date: 2019-07-22 last-updated: 2021-01-26 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-cluster-lifecycle/kubeadm/378-bootstrap-checkpointing/kep.yaml b/keps/sig-cluster-lifecycle/kubeadm/378-bootstrap-checkpointing/kep.yaml index 7470261aa83..5fb7928c86b 100644 --- a/keps/sig-cluster-lifecycle/kubeadm/378-bootstrap-checkpointing/kep.yaml +++ b/keps/sig-cluster-lifecycle/kubeadm/378-bootstrap-checkpointing/kep.yaml @@ -16,3 +16,5 @@ editor: "@timothysc" creation-date: 2017-10-20 last-updated: 2018-01-23 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-contributor-experience/0000-community-forum/kep.yaml b/keps/sig-contributor-experience/0000-community-forum/kep.yaml index 520cebd1d80..a5498c380fd 100644 --- a/keps/sig-contributor-experience/0000-community-forum/kep.yaml +++ b/keps/sig-contributor-experience/0000-community-forum/kep.yaml @@ -15,3 +15,5 @@ editor: TBD creation-date: 2018-04-03 last-updated: 2018-04-17 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-contributor-experience/1553-issue-triage/kep.yaml b/keps/sig-contributor-experience/1553-issue-triage/kep.yaml index b57436444f6..ebc0be26499 100644 --- a/keps/sig-contributor-experience/1553-issue-triage/kep.yaml +++ b/keps/sig-contributor-experience/1553-issue-triage/kep.yaml @@ -20,3 +20,5 @@ approvers: creation-date: 2020-02-15 see-also: replaces: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-contributor-experience/2225-contributor-site/kep.yaml b/keps/sig-contributor-experience/2225-contributor-site/kep.yaml index 2e597cd930f..34c0bb14a0f 100644 --- a/keps/sig-contributor-experience/2225-contributor-site/kep.yaml +++ b/keps/sig-contributor-experience/2225-contributor-site/kep.yaml @@ -15,3 +15,5 @@ editor: TBD creation-date: "2018-02-19" last-updated: "2021-01-04" status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-instrumentation/1206-metrics-overhaul/kep.yaml b/keps/sig-instrumentation/1206-metrics-overhaul/kep.yaml index d9dbf0decfb..14fbb839d62 100644 --- a/keps/sig-instrumentation/1206-metrics-overhaul/kep.yaml +++ b/keps/sig-instrumentation/1206-metrics-overhaul/kep.yaml @@ -14,3 +14,5 @@ editor: "@DirectXMan12" creation-date: 2018-11-06 last-updated: 2019-03-21 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-network/1024-nodelocal-cache-dns/kep.yaml b/keps/sig-network/1024-nodelocal-cache-dns/kep.yaml index 9b577ced582..17db0c3e3cf 100644 --- a/keps/sig-network/1024-nodelocal-cache-dns/kep.yaml +++ b/keps/sig-network/1024-nodelocal-cache-dns/kep.yaml @@ -16,3 +16,5 @@ last-updated: 2020-09-23 status: implemented see-also: - "/keps/sig-network/0030-nodelocal-dns-cache.md" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-network/2447-Make-kube-proxy-service-abstraction-optional/kep.yaml b/keps/sig-network/2447-Make-kube-proxy-service-abstraction-optional/kep.yaml index 487edc59822..9be2854aaa4 100644 --- a/keps/sig-network/2447-Make-kube-proxy-service-abstraction-optional/kep.yaml +++ b/keps/sig-network/2447-Make-kube-proxy-service-abstraction-optional/kep.yaml @@ -15,3 +15,5 @@ status: implemented see-also: replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-network/2448-Remove-kube-proxy-automatic-clean-up-logic/kep.yaml b/keps/sig-network/2448-Remove-kube-proxy-automatic-clean-up-logic/kep.yaml index 9c9cd66a8b8..b028a82058f 100644 --- a/keps/sig-network/2448-Remove-kube-proxy-automatic-clean-up-logic/kep.yaml +++ b/keps/sig-network/2448-Remove-kube-proxy-automatic-clean-up-logic/kep.yaml @@ -16,3 +16,5 @@ status: implemented see-also: replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-network/2449-move-externalDNS-out-of-kubernetes-incubator/kep.yaml b/keps/sig-network/2449-move-externalDNS-out-of-kubernetes-incubator/kep.yaml index 8ff93d520d3..5b4851c0519 100644 --- a/keps/sig-network/2449-move-externalDNS-out-of-kubernetes-incubator/kep.yaml +++ b/keps/sig-network/2449-move-externalDNS-out-of-kubernetes-incubator/kep.yaml @@ -7,3 +7,5 @@ approvers: - thockin owning-sig: sig-network status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-network/2450-Remove-knowledge-of-pod-cluster-CIDR-from-iptables-rules/kep.yaml b/keps/sig-network/2450-Remove-knowledge-of-pod-cluster-CIDR-from-iptables-rules/kep.yaml index 70ec10cd623..6d14715b310 100644 --- a/keps/sig-network/2450-Remove-knowledge-of-pod-cluster-CIDR-from-iptables-rules/kep.yaml +++ b/keps/sig-network/2450-Remove-knowledge-of-pod-cluster-CIDR-from-iptables-rules/kep.yaml @@ -23,3 +23,5 @@ status: implemented see-also: replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-network/265-ipvs-based-load-balancing/kep.yaml b/keps/sig-network/265-ipvs-based-load-balancing/kep.yaml index 5f2944c9083..4c1a2cabfd9 100644 --- a/keps/sig-network/265-ipvs-based-load-balancing/kep.yaml +++ b/keps/sig-network/265-ipvs-based-load-balancing/kep.yaml @@ -13,3 +13,5 @@ editor: "@thockin" creation-date: 2018-03-21 last-updated: 2019-06-27 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-network/980-load-balancer-finalizers/kep.yaml b/keps/sig-network/980-load-balancer-finalizers/kep.yaml index 2dc277cac20..62eb3fa6b16 100644 --- a/keps/sig-network/980-load-balancer-finalizers/kep.yaml +++ b/keps/sig-network/980-load-balancer-finalizers/kep.yaml @@ -21,3 +21,5 @@ status: implemented see-also: replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-node/135-seccomp/kep.yaml b/keps/sig-node/135-seccomp/kep.yaml index 5be881402ff..3e5b7f8c319 100644 --- a/keps/sig-node/135-seccomp/kep.yaml +++ b/keps/sig-node/135-seccomp/kep.yaml @@ -18,3 +18,5 @@ approvers: editor: "@saschagrunert" creation-date: 2019-07-17 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-node/1547-building-kubelet-without-docker/kep.yaml b/keps/sig-node/1547-building-kubelet-without-docker/kep.yaml index db56997b940..0afffe35abc 100644 --- a/keps/sig-node/1547-building-kubelet-without-docker/kep.yaml +++ b/keps/sig-node/1547-building-kubelet-without-docker/kep.yaml @@ -20,3 +20,5 @@ last-updated: 2020-05-11 status: implemented see-also: - "/keps/sig-cloud-provider/20190729-building-without-in-tree-providers.md" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-node/166-taint-based-eviction/kep.yaml b/keps/sig-node/166-taint-based-eviction/kep.yaml index e62c51bf72c..f72b92f50af 100644 --- a/keps/sig-node/166-taint-based-eviction/kep.yaml +++ b/keps/sig-node/166-taint-based-eviction/kep.yaml @@ -17,3 +17,5 @@ status: implemented see-also: replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-node/495-pod-pid-namespace/kep.yaml b/keps/sig-node/495-pod-pid-namespace/kep.yaml index 4895f18a97e..d52a4e796a7 100644 --- a/keps/sig-node/495-pod-pid-namespace/kep.yaml +++ b/keps/sig-node/495-pod-pid-namespace/kep.yaml @@ -1,15 +1,17 @@ title: Shared PID Namespace kep-number: 495 authors: -- "@verb" + - "@verb" owning-sig: sig-node participating-sigs: -- sig-node + - sig-node reviewers: -- "@yujuhong" + - "@yujuhong" approvers: -- "@dchen1107" + - "@dchen1107" editor: N/A creation-date: 2016-12-21 last-updated: 2019-09-30 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-node/589-efficient-node-heartbeats/kep.yaml b/keps/sig-node/589-efficient-node-heartbeats/kep.yaml index 9e766efd4b9..3182c4c3ff3 100644 --- a/keps/sig-node/589-efficient-node-heartbeats/kep.yaml +++ b/keps/sig-node/589-efficient-node-heartbeats/kep.yaml @@ -25,3 +25,5 @@ replaces: - n/a superseded-by: - n/a +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-node/757-pid-limiting/kep.yaml b/keps/sig-node/757-pid-limiting/kep.yaml index f4eadc41eeb..065d5851a90 100644 --- a/keps/sig-node/757-pid-limiting/kep.yaml +++ b/keps/sig-node/757-pid-limiting/kep.yaml @@ -17,3 +17,5 @@ status: implemented see-also: replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-node/950-liveness-probe-holdoff/kep.yaml b/keps/sig-node/950-liveness-probe-holdoff/kep.yaml index e7a0f178393..2487cf00af2 100644 --- a/keps/sig-node/950-liveness-probe-holdoff/kep.yaml +++ b/keps/sig-node/950-liveness-probe-holdoff/kep.yaml @@ -18,3 +18,5 @@ status: implemented see-also: replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-release/1733-release-notes/kep.yaml b/keps/sig-release/1733-release-notes/kep.yaml index fbcfc7db39f..533a96eea8d 100644 --- a/keps/sig-release/1733-release-notes/kep.yaml +++ b/keps/sig-release/1733-release-notes/kep.yaml @@ -18,3 +18,5 @@ editor: "@saschagrunert" creation-date: 2019-03-31 last-updated: 2021-01-12 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-scheduling/382-taint-node-by-condition/kep.yaml b/keps/sig-scheduling/382-taint-node-by-condition/kep.yaml index 38dde679f3a..ed3bc1f4bd6 100644 --- a/keps/sig-scheduling/382-taint-node-by-condition/kep.yaml +++ b/keps/sig-scheduling/382-taint-node-by-condition/kep.yaml @@ -17,3 +17,5 @@ last-updated: 2019-10-12 status: implemented see-also: - "https://github.com/kubernetes/community/blob/master/contributors/design-proposals/scheduling/taint-node-by-condition.md" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-scheduling/548-schedule-daemonset-pods/kep.yaml b/keps/sig-scheduling/548-schedule-daemonset-pods/kep.yaml index daca414d84b..4e58308aa6b 100644 --- a/keps/sig-scheduling/548-schedule-daemonset-pods/kep.yaml +++ b/keps/sig-scheduling/548-schedule-daemonset-pods/kep.yaml @@ -16,3 +16,5 @@ last-updated: 2019-10-11 status: implemented see-also: - "https://docs.google.com/document/d/10Ch3dhD88mnHYTq9q4jtX3e9e6gpndC78g5Ea6q4JY4/edit#heading=h.dtxm02f9bgaw" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-scheduling/986-resource-quota-scope-selectors/kep.yaml b/keps/sig-scheduling/986-resource-quota-scope-selectors/kep.yaml index 93fb9721621..26a286eb126 100644 --- a/keps/sig-scheduling/986-resource-quota-scope-selectors/kep.yaml +++ b/keps/sig-scheduling/986-resource-quota-scope-selectors/kep.yaml @@ -22,3 +22,5 @@ status: implemented see-also: replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-storage/121-local-persistent-volumes/kep.yaml b/keps/sig-storage/121-local-persistent-volumes/kep.yaml index bf518e63d3d..2c11e74cb3f 100644 --- a/keps/sig-storage/121-local-persistent-volumes/kep.yaml +++ b/keps/sig-storage/121-local-persistent-volumes/kep.yaml @@ -23,3 +23,5 @@ see-also: replaces: - "https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/local-storage-pv.md" superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-storage/1900-volume-snapshot-validation-webhook/kep.yaml b/keps/sig-storage/1900-volume-snapshot-validation-webhook/kep.yaml index ff336645f8c..395349c9350 100644 --- a/keps/sig-storage/1900-volume-snapshot-validation-webhook/kep.yaml +++ b/keps/sig-storage/1900-volume-snapshot-validation-webhook/kep.yaml @@ -25,3 +25,4 @@ milestone: beta: "v1.19" stable: "v1.20" disable-supported: true +stage: stable diff --git a/keps/sig-storage/351-raw-block-support/kep.yaml b/keps/sig-storage/351-raw-block-support/kep.yaml index e5841f91ca4..f20a707362c 100644 --- a/keps/sig-storage/351-raw-block-support/kep.yaml +++ b/keps/sig-storage/351-raw-block-support/kep.yaml @@ -16,3 +16,5 @@ last-updated: 2020-03-09 status: implemented see-also: - "https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/raw-block-pv.md" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-storage/554-maximum-volume-count/kep.yaml b/keps/sig-storage/554-maximum-volume-count/kep.yaml index 0751c3cde33..1480d987017 100644 --- a/keps/sig-storage/554-maximum-volume-count/kep.yaml +++ b/keps/sig-storage/554-maximum-volume-count/kep.yaml @@ -22,3 +22,5 @@ see-also: - "https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-migration.md" replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-storage/557-csi-topology/kep.yaml b/keps/sig-storage/557-csi-topology/kep.yaml index 2710a0f128b..5eca2aa4a00 100644 --- a/keps/sig-storage/557-csi-topology/kep.yaml +++ b/keps/sig-storage/557-csi-topology/kep.yaml @@ -21,3 +21,5 @@ replaces: - n/a superseded-by: - n/a +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-storage/559-volume-subpath-expansion/kep.yaml b/keps/sig-storage/559-volume-subpath-expansion/kep.yaml index 884cf319002..0252b2491c3 100644 --- a/keps/sig-storage/559-volume-subpath-expansion/kep.yaml +++ b/keps/sig-storage/559-volume-subpath-expansion/kep.yaml @@ -23,3 +23,5 @@ replaces: - n/a superseded-by: - n/a +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-storage/565-csi-block-support/kep.yaml b/keps/sig-storage/565-csi-block-support/kep.yaml index a007e4991d6..cf1706f5493 100644 --- a/keps/sig-storage/565-csi-block-support/kep.yaml +++ b/keps/sig-storage/565-csi-block-support/kep.yaml @@ -17,3 +17,5 @@ status: implemented see-also: - "https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/raw-block-pv.md" - "https://github.com/kubernetes/enhancements/pull/1288" +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-storage/603-csi-pod-info/kep.yaml b/keps/sig-storage/603-csi-pod-info/kep.yaml index 49fd1e50719..4da9053f102 100644 --- a/keps/sig-storage/603-csi-pod-info/kep.yaml +++ b/keps/sig-storage/603-csi-pod-info/kep.yaml @@ -18,3 +18,5 @@ see-also: - "https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/container-storage-interface-pod-information.md" replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-storage/770-csi-skip-attach/kep.yaml b/keps/sig-storage/770-csi-skip-attach/kep.yaml index 64dd4c2a33d..cf08a98cfe5 100644 --- a/keps/sig-storage/770-csi-skip-attach/kep.yaml +++ b/keps/sig-storage/770-csi-skip-attach/kep.yaml @@ -18,3 +18,5 @@ see-also: - "https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/container-storage-interface-skip-attach.md" replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-storage/989-extend-datasource/kep.yaml b/keps/sig-storage/989-extend-datasource/kep.yaml index 8ce925bd6e4..e294a60ed6a 100644 --- a/keps/sig-storage/989-extend-datasource/kep.yaml +++ b/keps/sig-storage/989-extend-datasource/kep.yaml @@ -17,3 +17,5 @@ status: implemented see-also: replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-windows/1043-windows-security-context/kep.yaml b/keps/sig-windows/1043-windows-security-context/kep.yaml index ebb5b3b4a53..d6bd565d89e 100644 --- a/keps/sig-windows/1043-windows-security-context/kep.yaml +++ b/keps/sig-windows/1043-windows-security-context/kep.yaml @@ -17,3 +17,5 @@ see-also: - "keps/sig-windows/20181221-windows-group-managed-service-accounts-for-container-identity.md" replaces: superseded-by: +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-windows/116-windows-node-support/kep.yaml b/keps/sig-windows/116-windows-node-support/kep.yaml index 876f0aff925..0eb95bf6f2e 100644 --- a/keps/sig-windows/116-windows-node-support/kep.yaml +++ b/keps/sig-windows/116-windows-node-support/kep.yaml @@ -24,3 +24,5 @@ editor: TBD creation-date: 2018-11-29 last-updated: 2019-03-06 status: implemented +latest-milestone: '0.0' +stage: stable diff --git a/keps/sig-windows/689-windows-gmsa/kep.yaml b/keps/sig-windows/689-windows-gmsa/kep.yaml index eedd463da24..6fcb1204b5d 100644 --- a/keps/sig-windows/689-windows-gmsa/kep.yaml +++ b/keps/sig-windows/689-windows-gmsa/kep.yaml @@ -23,3 +23,5 @@ editor: TBD creation-date: 2018-11-29 last-updated: 2020-03-20 status: implemented +latest-milestone: '0.0' +stage: stable From 105f03438524e96feff5771ac8b895ef1446d845 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Fri, 8 Oct 2021 10:31:41 -0700 Subject: [PATCH 04/12] keps/sig-cli: 2206 status: implementable Looking through history, consensus seemed to be that implemented status is reserved for KEPs that have `stage: stable`, so this should remain at implementable --- keps/sig-cli/2206-openapi-features-in-kustomize/kep.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/keps/sig-cli/2206-openapi-features-in-kustomize/kep.yaml b/keps/sig-cli/2206-openapi-features-in-kustomize/kep.yaml index 119910e8995..df38abd8a87 100644 --- a/keps/sig-cli/2206-openapi-features-in-kustomize/kep.yaml +++ b/keps/sig-cli/2206-openapi-features-in-kustomize/kep.yaml @@ -13,7 +13,7 @@ approvers: - "@pwittrock" creation-date: 2020-12-21 last-updated: 2020-01-15 -status: implemented +status: implementable latest-milestone: "1.22" stage: "beta" From dd3cb63f13e2a181ba40a52b17f2140f906b1c4d Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Fri, 8 Oct 2021 09:57:59 -0700 Subject: [PATCH 05/12] keps/sig-release: 1498 stage: stable This is implemented so its stage should be stable --- keps/sig-release/1498-kubernetes-yearly-support-period/kep.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/keps/sig-release/1498-kubernetes-yearly-support-period/kep.yaml b/keps/sig-release/1498-kubernetes-yearly-support-period/kep.yaml index 75dac3a3596..832a6c25548 100644 --- a/keps/sig-release/1498-kubernetes-yearly-support-period/kep.yaml +++ b/keps/sig-release/1498-kubernetes-yearly-support-period/kep.yaml @@ -26,6 +26,7 @@ approvers: creation-date: 2020-01-22 latest-milestone: v1.19 status: implemented +stage: stable see-also: replaces: superseded-by: From 6411a4dd8ee108dcf8f3f7559be31736e56ddae3 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Fri, 8 Oct 2021 10:08:45 -0700 Subject: [PATCH 06/12] keps/sig-release: 0000 stage: stable This is implemented so its stage should be stable --- keps/sig-release/0000-anago-to-krel-migration/kep.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/keps/sig-release/0000-anago-to-krel-migration/kep.yaml b/keps/sig-release/0000-anago-to-krel-migration/kep.yaml index 89670b2d829..b2d0f3319d9 100644 --- a/keps/sig-release/0000-anago-to-krel-migration/kep.yaml +++ b/keps/sig-release/0000-anago-to-krel-migration/kep.yaml @@ -10,3 +10,4 @@ approvers: creation-date: 2020-09-22 latest-milestone: v1.20 status: implemented +stage: stable From cf70bb1e5df5132b55a3e80b9f90f87144ddf757 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Fri, 8 Oct 2021 09:50:05 -0700 Subject: [PATCH 07/12] keps/sig-testing: 2539 status: implementable It seems consensus is that implemented should only be used once stage is stable. We're not there yet on this KEP, so drop back to implementable --- keps/sig-testing/2539-continuously-deploy-k8s-prow/kep.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/keps/sig-testing/2539-continuously-deploy-k8s-prow/kep.yaml b/keps/sig-testing/2539-continuously-deploy-k8s-prow/kep.yaml index 1299796fb7c..de6062842ed 100644 --- a/keps/sig-testing/2539-continuously-deploy-k8s-prow/kep.yaml +++ b/keps/sig-testing/2539-continuously-deploy-k8s-prow/kep.yaml @@ -6,7 +6,7 @@ owning-sig: sig-testing participating-sigs: - sig-testing - sig-release -status: implemented +status: implementable creation-date: 2021-02-23 last-updated: 2021-08-16 reviewers: From a5a70712d39398f2ed2d08711a80d8224ec3c4c9 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Fri, 8 Oct 2021 10:18:29 -0700 Subject: [PATCH 08/12] keps/prod-readiness: add sig-architecture/1143 This was marked as stable in v1.21 as of 2021-04-xx. The PRR check is only valid for anything v1.21 or later, but wasn't marked as required until 2021-05-05. I'm not sure if this never went through review, was previously exempt, etc. --- keps/prod-readiness/sig-architecture/1143.yaml | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 keps/prod-readiness/sig-architecture/1143.yaml diff --git a/keps/prod-readiness/sig-architecture/1143.yaml b/keps/prod-readiness/sig-architecture/1143.yaml new file mode 100644 index 00000000000..62ad41b1804 --- /dev/null +++ b/keps/prod-readiness/sig-architecture/1143.yaml @@ -0,0 +1,3 @@ +kep-number: 1143 +stable: + approver: "@wojtek-t" From 3f4b24590beed4b0696b015c1c31e2e9d60c6db7 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Fri, 8 Oct 2021 10:25:40 -0700 Subject: [PATCH 09/12] keps/prod-readiness: add sig-testing/2539 This went to beta in v1.21 before PRR was mandated as required. It's a tooling/process KEP that doesn't affect the contents of a kubernetes release, so I expect this to be a rubber stamp --- keps/prod-readiness/sig-testing/2539.yaml | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 keps/prod-readiness/sig-testing/2539.yaml diff --git a/keps/prod-readiness/sig-testing/2539.yaml b/keps/prod-readiness/sig-testing/2539.yaml new file mode 100644 index 00000000000..afb5fe233b8 --- /dev/null +++ b/keps/prod-readiness/sig-testing/2539.yaml @@ -0,0 +1,3 @@ +kep-number: 2539 +beta: + approver: "@johnbelamaric" From a28ce6dd506312f4c47306023b57a64cc58112df Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Fri, 8 Oct 2021 10:33:25 -0700 Subject: [PATCH 10/12] keps/prod-readiness: add sig-cli/2206 This was retroactively marked as implemented @ beta during v1.22. It's not clear to me whether this should have gone through PRR --- keps/prod-readiness/sig-cli/2206.yaml | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 keps/prod-readiness/sig-cli/2206.yaml diff --git a/keps/prod-readiness/sig-cli/2206.yaml b/keps/prod-readiness/sig-cli/2206.yaml new file mode 100644 index 00000000000..8962cdde6e6 --- /dev/null +++ b/keps/prod-readiness/sig-cli/2206.yaml @@ -0,0 +1,3 @@ +kep-number: 2206 +beta: + approver: "@johnbelamaric" From 6f464ad1e122b1db784ba4ffcb6108ca36690ca9 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Wed, 13 Oct 2021 12:41:23 -0700 Subject: [PATCH 11/12] api: validate status:implemented == stage:stable --- api/proposal.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/api/proposal.go b/api/proposal.go index 19ef455b16b..64cc9ceb61e 100644 --- a/api/proposal.go +++ b/api/proposal.go @@ -257,6 +257,9 @@ func (k *KEPHandler) Validate(p *Proposal) []error { if err := p.Stage.IsValid(); err != nil { allErrs = append(allErrs, err) } + if p.Status == ImplementedStatus && p.Stage != StableStage { + allErrs = append(allErrs, fmt.Errorf("status:implemented implies stage:stable but found: %v", p.Stage)) + } return allErrs } From 4b78b37bca56b5703a988406b94ae86f03eccdca Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Wed, 13 Oct 2021 12:40:45 -0700 Subject: [PATCH 12/12] keps: add prod-readiness and stage:stable for sig-auth/2097 --- keps/prod-readiness/sig-auth/2907.yaml | 3 +++ keps/sig-auth/2907-secrets-store-csi-driver/kep.yaml | 1 + 2 files changed, 4 insertions(+) create mode 100644 keps/prod-readiness/sig-auth/2907.yaml diff --git a/keps/prod-readiness/sig-auth/2907.yaml b/keps/prod-readiness/sig-auth/2907.yaml new file mode 100644 index 00000000000..a6fdb38dcaf --- /dev/null +++ b/keps/prod-readiness/sig-auth/2907.yaml @@ -0,0 +1,3 @@ +kep-number: 2907 +stable: + approver: "@johnbelamaric" diff --git a/keps/sig-auth/2907-secrets-store-csi-driver/kep.yaml b/keps/sig-auth/2907-secrets-store-csi-driver/kep.yaml index bf445f26452..c694487b508 100644 --- a/keps/sig-auth/2907-secrets-store-csi-driver/kep.yaml +++ b/keps/sig-auth/2907-secrets-store-csi-driver/kep.yaml @@ -14,3 +14,4 @@ approvers: - "@ritazh" - "@mikedanese" status: implemented +stage: stable