-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL certificate name non-unique when namespace + ingress name too long #131
Comments
A colleague and I were just discussing this yesterday, as a hypothetical issue. I see it's no longer hypothetical. |
Yes, this has come up several times in discussions. Unfortunately, there's currently no plan to migrate to a better naming scheme. |
Migrating sounds pretty tough but how about handling the error better?
The behavior I saw is the certificate of an already existing load balancer was removed from it and added to the new one, and then it began bouncing back and forth. As the service uses HSTS, this meant it was completely unavailable during periods where it didn't have the certificate. Luckily this wasn't a user facing service, but it could potentially cause a severe production outage from an innocent looking ingress addition so handling it a little better seems important. |
Do we have an agreed upon new naming scheme that fixes the problem, so that we can use it for new resources? |
This issue should be fixed in v1.1.1. We migrated to a new naming scheme for certs which eliminates the issue of truncation when the name is too long (see #200). Closing for now, but please reopen if you still have issues. |
I recently ran into an issue where due to a combination of somewhat long namespace + ingress name, a GCE load balancer was created for each of two ingresses with very similar name
and the SSL certificate configured for both had the same name
k8s-ssl-abcdefghijklmn-abcde-prod-abcdefghijklmn-admin-server-0
While it seems GCP allows this, other ingress-aware components, in my case cert-manager, can get confused and the issue I saw was the SSL certificate being bounced between the two load balancers. As cert-manager presumably has no idea what the GCP load balancer name / SSL cert name is for an ingress, I guess the issue is in the ingress controller. Either it should correctly operate ingresses of different names which happen to have the same name of load balancer / SSL cert, or ingresses should be rejected if they would result in too long a name to be unique.
The text was updated successfully, but these errors were encountered: