Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does/will the GCE ingress controller support whitelist-source-range? #38

Closed
bowei opened this issue Oct 11, 2017 · 17 comments
Closed

Does/will the GCE ingress controller support whitelist-source-range? #38

bowei opened this issue Oct 11, 2017 · 17 comments
Labels
backend/gce kind/feature Categorizes issue or PR as related to a new feature.

Comments

@bowei
Copy link
Member

bowei commented Oct 11, 2017

From @nickform on April 6, 2017 12:11

Can anyone comment on when we will be able to use the 'whitelist-source-range' annotation with the GCE Ingress Controller? From Googling plus experimentation the answer is not "it works right now" but perhaps we've made a mistake? If not, is this something which might happen in future? Thanks!

Copied from original issue: kubernetes/ingress-nginx#566

@bowei
Copy link
Member Author

bowei commented Oct 11, 2017

From @nicksardo on April 6, 2017 17:59

The L7 Google Cloud Load Balancer does not currently have firewall rules for source IPs. I'll keep this open in case the load balancer supports it in the future.

@bowei
Copy link
Member Author

bowei commented Oct 11, 2017

From @albertsun on April 28, 2017 17:6

This would be extremely useful to have. @nicksardo is there an open issue somewhere for the L7 LB to support source IP firewall rules where we can track the status of it?

@bowei
Copy link
Member Author

bowei commented Oct 11, 2017

From @nicksardo on April 28, 2017 17:30

https://issuetracker.google.com/issues/35904903

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2018
@nicksardo nicksardo removed their assignment Jan 11, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 11, 2018
@mooperd
Copy link

mooperd commented Feb 12, 2018

Hi, what is the status of this issue? We'd like to be able to control access to specific k8s services. This seems like the most likely way of handling it.

Found this issue in google issue tracker: https://issuetracker.google.com/issues/35904903

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 12, 2018
@tonglil
Copy link
Contributor

tonglil commented Feb 22, 2018

It is still relevant. The bug tracker also receives +1s on a regular basis.

@ghost
Copy link

ghost commented Mar 28, 2018

Now that we have Cloud Armor and can restrict ingress based on IP, it would be interesting to incorporate Cloud Armor rules in ingress annotations.

Is there a plan for that?

@rramkumar1
Copy link
Contributor

@Slabber Cloud Armor integration with ingress-gce will be coming very soon :)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed enhancement labels Jun 5, 2018
@nicksardo
Copy link
Contributor

/close
Now available in latest version of ingress-gce.

@cfebs
Copy link

cfebs commented Jul 17, 2018

@nicksardo - is a specific k8s version required to use the whitelist annotation? Or will it just start working for gce ingress?

@nickform
Copy link

This is great news - thanks to everyone who has tracked and worked on this.

@guilhermeShima
Copy link

Anyone was able to use the whitelist annotation in GCE ?

@rramkumar1
Copy link
Contributor

rramkumar1 commented Jul 24, 2018

Documentation for all our new feature support (IAP, CDN, CloudArmor) is available at https://cloud.google.com/kubernetes-engine/docs/concepts/backendconfig.

I will work on a PR to add this same documentation to the README here.

@mnemitz
Copy link

mnemitz commented Jan 10, 2019

I know this is closed, but just wondering, is there any plan to support a whitelist/CloudArmor annotation at the ingress resource level?

@rramkumar1
Copy link
Contributor

@vTNT
Copy link

vTNT commented Feb 21, 2019

It's not a very good plan. It's too complicated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/gce kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests