Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split CRD creation out of GLBC #744

Closed
dekkagaijin opened this issue May 1, 2019 · 3 comments
Closed

Split CRD creation out of GLBC #744

dekkagaijin opened this issue May 1, 2019 · 3 comments
Assignees
@rramkumar1
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@dekkagaijin
Copy link

Creation of CRDs should be split from the implementation of the controller itself:

ingress-gce/cmd/glbc/main.go

Line 93 in 4918eb2

if _, err := crdHandler.EnsureCRD(backendConfigCRDMeta); err != nil {

/assign rramkumar1
@dekkagaijin dekkagaijin mentioned this issue May 1, 2019
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2019
@rramkumar1 rramkumar1 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 31, 2019
@freehan
Copy link
Contributor

freehan commented Jan 4, 2022 •
edited
Loading

I am wondering what is the benefit of doing this? Something would still need to ensure the CRD, right?

@swetharepakula
Copy link
Member

We currently do not plan on making this change.

@swetharepakula swetharepakula closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rramkumar1 rramkumar1

Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dekkagaijin @freehan @swetharepakula @k8s-ci-robot @rramkumar1 @fejta-bot