From 90d9da0f47ceac3e8d5c21fc265f4df7daa5241a Mon Sep 17 00:00:00 2001
From: Nick Sardo <nicksardo@google.com>
Date: Tue, 12 Jun 2018 12:35:18 -0700
Subject: [PATCH] Add quotes to echo, allow CONTAINER_BINARIES override

---
 Makefile       |  2 +-
 build/rules.mk | 14 +++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Makefile b/Makefile
index b15d78e13d..23389abee4 100644
--- a/Makefile
+++ b/Makefile
@@ -21,7 +21,7 @@ PKG := k8s.io/ingress-gce
 
 # List of binaries to build. You must have a matching Dockerfile.BINARY
 # for each BINARY.
-CONTAINER_BINARIES := \
+CONTAINER_BINARIES ?= \
 	e2e-test \
 	echo \
 	fuzzer \
diff --git a/build/rules.mk b/build/rules.mk
index 8cc6ef09cf..273a2b69f3 100644
--- a/build/rules.mk
+++ b/build/rules.mk
@@ -130,7 +130,7 @@ $(GO_BINARIES): build-dirs
 # Rules for dockerfiles.
 define DOCKERFILE_RULE
 .$(BINARY)-$(ARCH)-dockerfile: Dockerfile.$(BINARY)
-	@echo generating Dockerfile $$@ from $$<
+	@echo "generating Dockerfile $$@ from $$<"
 	@sed					\
 	    -e 's|ARG_ARCH|$(ARCH)|g' \
 	    -e 's|ARG_BIN|$(BINARY)|g' \
@@ -233,7 +233,7 @@ endif
 # Miscellaneous rules
 .PHONY: version
 version:
-	@echo $(VERSION)
+	@echo "$(VERSION)"
 
 .PHONY: build-dirs
 build-dirs:
@@ -254,20 +254,20 @@ bin-clean:
 .PHONY: help
 help:
 	@echo "make targets"
-	@echo
+	@echo ""
 	@echo "  all, build    build all binaries"
 	@echo "  containers    build the containers"
 	@echo "  push          push containers to the registry"
 	@echo "  help          this help message"
 	@echo "  version       show package version"
-	@echo
+	@echo ""
 	@echo "  {build,containers,push}-ARCH    do action for specific ARCH"
 	@echo "  all-{build,containers,push}     do action for all ARCH"
 	@echo "  only-push-BINARY                push just BINARY"
-	@echo
+	@echo ""
 	@echo "  Available ARCH: $(ALL_ARCH)"
 	@echo "  Available BINARIES: $(ALL_BINARIES)"
-	@echo
+	@echo ""
 	@echo "  Setting VERBOSE=1 will show additional build logging."
-	@echo
+	@echo ""
 	@echo "  Setting VERSION will override the container version tag."