fixes #8168 by appending elements on match, instead of removing

kubernetes · Jan 25, 2022 · 94870b8 · 94870b8
1 parent 922e27f
commit 94870b8
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/internal/ingress/annotations/cors/main.go b/internal/ingress/annotations/cors/main.go
@@ -123,16 +123,18 @@ func (c cors) Parse(ing *networking.Ingress) (interface{}, error) {
 
 	unparsedOrigins, err := parser.GetStringAnnotation("cors-allow-origin", ing)
 	if err == nil {
-		config.CorsAllowOrigin = strings.Split(unparsedOrigins, ",")
-		for i, origin := range config.CorsAllowOrigin {
+		origins := strings.Split(unparsedOrigins, ",")
+		for _, origin := range origins {
 			origin = strings.TrimSpace(origin)
 			if origin == "*" {
 				config.CorsAllowOrigin = []string{"*"}
 				break
 			}
-			if !corsOriginRegex.MatchString(origin) {
+
+			if corsOriginRegex.MatchString(origin) {
+				config.CorsAllowOrigin = append(config.CorsAllowOrigin, origin)
+			} else {
 				klog.Errorf("Error parsing cors-allow-origin parameters. Supplied incorrect origin: %s. Skipping.", origin)
-				config.CorsAllowOrigin = append(config.CorsAllowOrigin[:i], config.CorsAllowOrigin[i+1:]...)
 			}
 			klog.Infof("Current config.corsAllowOrigin %v", config.CorsAllowOrigin)
 		}