Chart: Align HPA & KEDA conditions.

[Gacko]

Currently some of the Helm chart templates contain conditions checking if HPA (controller.autoscaling) and/or KEDA (controller.keda) is enabled or not.

The PDB for example only gets rendered if HPA is disabled and the static replica count is greater than 1 or if HPA is enabled and its minimum replica count is greater than 1. KEDA is not being considered here.

The HPA only gets rendered if it's enabled and KEDA is disabled. For KEDA we are only checking if KEDA is enabled, not if HPA is disabled.

There are more examples, so to sum things up: Search for usages of either controller.autoscaling.enabled or controller.keda.enabled and check that both of them are checked in a way it makes sense and is consistent all over the chart.

[Gacko]

/assign

[Gacko]

/priority backlog
/triage accepted

[github-actions]

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

[Gacko]

/remove-lifecycle frozen

[StuxxNet]

@Gacko if you want I can also give a try on this one based on the last contribution. What do you think? I might need some guidance, but would happily help!

[Gacko]

I already have something prepared for that locally. Once I pushed it and created a PR for it, I'd be glad to get some review from you!