Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag controller-1.10.0 is pointing to 1.9.6 #11041

Closed
Ulrar opened this issue Feb 29, 2024 · 7 comments
Closed

Tag controller-1.10.0 is pointing to 1.9.6 #11041

Ulrar opened this issue Feb 29, 2024 · 7 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Ulrar
Copy link

Ulrar commented Feb 29, 2024

Hi,

Looks like the controller-1.10.0 tag is pointing to (or contains, at least) version 1.9.6 :
https://raw.githubusercontent.com/kubernetes/ingress-nginx/controller-v1.10.0/deploy/static/provider/baremetal/deploy.yaml

Same thing happened on the last release (see #10940).

Thanks

@Ulrar Ulrar added the kind/bug Categorizes issue or PR as related to a bug. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Feb 29, 2024
@longwuyuan
Copy link
Contributor

/triage accepted
/priority important-soon

cc @tao12345666333 @strongjz @rikatz

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 29, 2024
@rikatz
Copy link
Contributor

rikatz commented Feb 29, 2024

I'm on the road now, if this is a simple fix can you submit a PR to main branch?

Thanks!!!

@Ulrar
Copy link
Author

Ulrar commented Feb 29, 2024

Is is just replacing 1.9.6 by 1.10.0 in the yaml, and pulling the related sha256 for the image tag ? If so, I can sure.
Just want to confirm this version doesn't require any changes to any other part of the manifest ?

@longwuyuan
Copy link
Contributor

That URL with the tag embedded in it happens as part of the release process.

The manifest itself is fine if you look it up in the browser on the repo (both in the main branch as well as the v1.10 branch)

@strongjz will have comments and the solution so please wait

@strongjz
Copy link
Member

The github release usually generates the tag that points to the PR to main with the updated yamls. I'm in central tz, and I'll do this asap.

@strongjz
Copy link
Member

/assign

@strongjz
Copy link
Member

Fixed. updated the git tag on the release to point to #11039
6aa2618

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

No branches or pull requests

5 participants