Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc error about traffic mirror #11432

Closed
huangmu1987 opened this issue Jun 7, 2024 · 3 comments · Fixed by #11433
Closed

doc error about traffic mirror #11432

huangmu1987 opened this issue Jun 7, 2024 · 3 comments · Fixed by #11433
Labels
area/docs kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@huangmu1987
Copy link

What happened:

while using mirror feature to foward traffic to another backend as document of
https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#mirror

this example will lead to a mistake of adding an extra "/" between domain name and uri
nginx.ingress.kubernetes.io/mirror-target: https://test.env.com/$request_uri

should be https://test.env.com$request_uri

@huangmu1987 huangmu1987 added the kind/bug Categorizes issue or PR as related to a bug. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jun 7, 2024
@longwuyuan
Copy link
Contributor

I am testing this and I am finding at least one problem. The subrequest upstream hostname changes to the resolved ipaddress of the upstream(mirror).

And I get the request going to the upstream and don't have trace or proper tcpdump configured to know the request URL received by the mirror.

Can you share screen on meet.jit.si and show your test environment where you discoverd this documentation fault.

@longwuyuan
Copy link
Contributor

longwuyuan commented Jun 7, 2024

But i see the directive set as
image

And this page https://nginx.org/en/docs/http/ngx_http_mirror_module.html

image

is proof that what you reported is a genuine documentation bug. Hoping to remove that '/ asap.

Thanks for reporting this

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 7, 2024
@longwuyuan
Copy link
Contributor

/kind documentation
/area docs

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/docs labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants