Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NGINX_BASE to new tag or revert TAG #11514

Closed
ipaqsa opened this issue Jun 27, 2024 · 3 comments
Closed

Bump NGINX_BASE to new tag or revert TAG #11514

ipaqsa opened this issue Jun 27, 2024 · 3 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@ipaqsa
Copy link
Contributor

ipaqsa commented Jun 27, 2024

I recently have bumped nginx 1.25 image to 1.25.5(#11470), and updated the image TAG, and i am still not sure that it was the right. But if we merged this PR, i think we should bump NGINX_BASE image(which is used for tests) to a new TAG or we need to revert TAG. I didn't do it because I don't know the process.

And there is another problem that build was not successful(https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-ingress-nginx-push-images/1803148085384187904) and v0.0.7 is not present in the registry. This affects this PR #10984

@ipaqsa ipaqsa added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ipaqsa ipaqsa changed the title Bump NGINX_BASE to new tag Bump NGINX_BASE to new tag or revert TAG Jun 27, 2024
@strongjz
Copy link
Member

strongjz commented Jul 1, 2024

GCP Cloud build has to pass so it's in the staging registry and then we promote in the k8s.io to production, then we can put in a PR to update in our NGINX_BASE image.

https://github.com/kubernetes/ingress-nginx/blob/main/MANUAL_RELEASE.md#2-if-applicable-build-other-images

@strongjz strongjz self-assigned this Jul 1, 2024
@ipaqsa
Copy link
Contributor Author

ipaqsa commented Jul 1, 2024

@strongjz Thanks, i got it!

@ipaqsa ipaqsa closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

3 participants