Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krew plugin need update #7627

Closed
cnscud opened this issue Sep 13, 2021 · 19 comments · Fixed by #8812
Closed

krew plugin need update #7627

cnscud opened this issue Sep 13, 2021 · 19 comments · Fixed by #8812
Assignees
@tao12345666333 @Volatus
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@cnscud
Copy link

cnscud commented Sep 13, 2021

It is 0.31, not the latest version.
@cnscud cnscud added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 13, 2021
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Sep 13, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 12, 2021
@tao12345666333
Copy link
Member

/assign let me update it.

@tao12345666333
Copy link
Member

/assign

@tao12345666333
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 12, 2021
@tao12345666333
Copy link
Member

In fact, our new version (v1.x) did not release a separate binary file at the time of release.

According to krew's documentation, we can automate it. https://krew.sigs.k8s.io/docs/developer-guide/release/automating-updates/

I want to discuss whether we need to maintain it.
/cc @rikatz @strongjz

@rikatz
Copy link
Contributor

rikatz commented Dec 12, 2021

I'm a +1 for this! I did that with a pet project myself, using goreleaser and a gh action to update the plugin.

@tao12345666333
Copy link
Member

In fact, our new version (v1.x) did not release a separate binary file at the time of release.

@rikatz Then we need to upload the binary file when we release.

@rikatz
Copy link
Contributor

rikatz commented Dec 12, 2021

Yup. Go releaser can do that :)

@tao12345666333
Copy link
Member

 👌 I will handle it

@tao12345666333
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 12, 2021
@tao12345666333
Copy link
Member

@rikatz I found that we already have a job, but it is disabled https://github.com/kubernetes/ingress-nginx/blob/main/.github/workflows/release.txt

xref: #5436

@tao12345666333
Copy link
Member

I will try to enable it and use it with https://github.com/rajatjindal/krew-release-bot

@tao12345666333 tao12345666333 mentioned this issue Jan 5, 2022
Closed
@ElvinEfendi
Copy link
Member

@tao12345666333 is there any blocker here?

@tao12345666333
Copy link
Member

Not currently, I am testing it, and I can submit a PR within this week to complete it

@tao12345666333 tao12345666333 mentioned this issue Jan 26, 2022
Closed
@tao12345666333
Copy link
Member

#8194 is another case.

I'm sorry for the delay, but I should be able to make time for it this week.

@jsoref
Copy link
Contributor

jsoref commented Mar 21, 2022

It was disabled by @aledbf in #5434 with no explanation.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 20, 2022
@jsoref
Copy link
Contributor

jsoref commented Jun 20, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 20, 2022
@Volatus
Copy link
Contributor

Volatus commented Jul 11, 2022

/assign

@Volatus Volatus mentioned this issue Jul 12, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tao12345666333 tao12345666333

@Volatus Volatus

Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reimplement kubectl plugin release workflow Volatus/ingress-nginx
8 participants
@cnscud @ElvinEfendi @jsoref @tao12345666333 @rikatz @k8s-ci-robot @Volatus @k8s-triage-robot