Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart should allow adding annotations for admission-webhooks Jobs #7978

Closed
onimsha opened this issue Nov 26, 2021 · 1 comment · Fixed by #7979
Closed

Helm chart should allow adding annotations for admission-webhooks Jobs #7978

onimsha opened this issue Nov 26, 2021 · 1 comment · Fixed by #7979
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@onimsha
Copy link
Contributor

onimsha commented Nov 26, 2021

Currently we're allowing to set the annotations for the controller , but not in the admission-webhooks Jobs. I think we should support it, for example in my use case is i want to add certain annotations to the Jobs to pass the kube-linter checks.

Proposed changing following files: job-patchWebhook.yaml and job-createSecret.yaml

  annotations:
    "helm.sh/hook": pre-install,pre-upgrade
    "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
    {{- with .Values.controller.admissionWebhooks.annotations }}
    {{- toYaml . | nindent 4 }}
    {{- end }}
@onimsha onimsha added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 26, 2021
@k8s-ci-robot
Copy link
Contributor

@onimsha: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants