doc: Broken link for deploy.yaml for AWS NLB with TLS Termination

[glyhood]

There's a broken link in the documentation https://kubernetes.github.io/ingress-nginx/deploy/#aws which needs to be updated.

The deploy.yaml links in the AWS section should be updated/fixed for the TLS TERMINATION IN AWS LOAD BALANCER (NLB)

This doesn't work: https://raw.githubusercontent.com/kubernetes/ingress-nginx/controller-v1.1.1/deploy/static/provider/aws/nlb-with-tls-termination/deploy.yaml

Seems it's been changed to this: https://raw.githubusercontent.com/kubernetes/ingress-nginx/main/deploy/static/provider/aws/nlb-with-tls-termination/deploy.yaml

[k8s-ci-robot]

@glyhood: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

@glyhood , Thanks for reporting this. Verified that controller version in the URL is broken.
Now we need to figure out root cause and if other manifests also are broken.

@afirth , can you help on this. Need to know if there is any impact from kustomize based manifest generation and if other static manifests path also needs changing.

[longwuyuan]

/triage-accepted
/kind documentation
/area docs

[longwuyuan]

/remove-kind bug

[longwuyuan]

Just checked the GKE URL works with the controller version.
That means the problem is unique to https://raw.githubusercontent.com/kubernetes/ingress-nginx/controller-v1.1.1/deploy/static/provider/aws/nlb-with-tls-termination/deploy.yaml
And at least one uniqueness is that its under a subdir of the deploy subdir (double subdirs)

[afirth]

/assign @afirth

[afirth]

This manifest was always a special case, aws is the only provider with two different manifests. Previously it was at deploy-tls-termination.yaml. I moved it to a subdir in #8099. The problem, I believe, is that the docs for latest follow main, not what was released. Since the manifest doesn't exist in the controller-v1.1.1 branch I don't really see how it can be fixed until the next release, but it should be fixed automagically during the next release.

You can see that in the v1.1.1 copy of the docs the link correctly points to the previous location, and in main the file exists.

I don't believe any action is required here, but apologies for the inconvenience. BTW @glyhood , if you are installing on something besides K8s 1.20 you may prefer to use the manifests at https://github.com/kubernetes/ingress-nginx/pull/8162/files instead

@longwuyuan not sure if you would normally close wont-fix or leave open until the next release.

/unassign @afirth

[longwuyuan]

Thanks. Let's keep it open for now. Trying to make a chart release soon. App release needs others input. Thanks, ; Long

…

On Sat, 29 Jan, 2022, 8:11 PM Alastair Firth, ***@***.***> wrote: This manifest was always a special case, aws is the only provider with two different manifests. Previously it was at deploy-tls-termination.yaml. I moved it to a subdir in #8099 <#8099>. The problem, I believe, is that the docs for latest follow main, not what was released. Since the manifest doesn't exist in the controller-v1.1.1 branch I don't really see how it can be fixed until the next release, but it should be fixed automagically during the next release. You can see that in the v1.1.1 copy of the docs <https://github.com/kubernetes/ingress-nginx/blob/controller-v1.1.1/docs/deploy/index.md#tls-termination-in-aws-load-balancer-nlb> the link correctly points to the previous location, and in main the file exists. I don't believe any action is required here, but apologies for the inconvenience. BTW @glyhood <https://github.com/glyhood> , if you are installing on something besides K8s 1.20 you may prefer to use the manifests at https://github.com/kubernetes/ingress-nginx/pull/8162/files instead @longwuyuan <https://github.com/longwuyuan> not sure if you would normally close wont-fix or leave open until the next release. /unassign @afirth <https://github.com/afirth> — Reply to this email directly, view it on GitHub <#8206 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWVN3TPQTZDUNB5CVA3UYP37XANCNFSM5NCZSR6A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[afirth]

👍 sounds good. I think the ideal solution would be to have versioned docs like e.g. cert-manager. old, stable, next. But these are available in markdown form in the repo so 🤷

[longwuyuan]

On another thought, the GKE manifests are "following the release". Do you have any comments on what will url for other providers after next app release. And if the ghpages website will update links in that kunctl apply box. Thanks, ; Long

…

On Sat, 29 Jan, 2022, 8:31 PM Yuan, ***@***.***> wrote: Thanks. Let's keep it open for now. Trying to make a chart release soon. App release needs others input. Thanks, ; Long On Sat, 29 Jan, 2022, 8:11 PM Alastair Firth, ***@***.***> wrote: > This manifest was always a special case, aws is the only provider with > two different manifests. Previously it was at deploy-tls-termination.yaml. > I moved it to a subdir in #8099 > <#8099>. The problem, I > believe, is that the docs for latest follow main, not what was released. > Since the manifest doesn't exist in the controller-v1.1.1 branch I don't > really see how it can be fixed until the next release, but it should be > fixed automagically during the next release. > > You can see that in the v1.1.1 copy of the docs > <https://github.com/kubernetes/ingress-nginx/blob/controller-v1.1.1/docs/deploy/index.md#tls-termination-in-aws-load-balancer-nlb> > the link correctly points to the previous location, and in main the file > exists. > > I don't believe any action is required here, but apologies for the > inconvenience. BTW @glyhood <https://github.com/glyhood> , if you are > installing on something besides K8s 1.20 you may prefer to use the > manifests at https://github.com/kubernetes/ingress-nginx/pull/8162/files > instead > > @longwuyuan <https://github.com/longwuyuan> not sure if you would > normally close wont-fix or leave open until the next release. > > /unassign @afirth <https://github.com/afirth> > > — > Reply to this email directly, view it on GitHub > <#8206 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABGZVWVN3TPQTZDUNB5CVA3UYP37XANCNFSM5NCZSR6A> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[afirth]

Only this manifest moved, no other providers should be affected. As to ghpages updating the links, I added there is a doc generator somewhere but I'm not familiar with it.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.