Metrics service in Helm chart should have protocol in port name

[anders-swanson]

The controller-service-metrics port in the ingress-nginx helm chart is missing a protocol prefix for the K8s Service port name: https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/templates/controller-service-metrics.yaml#L34

The service port name should follow the convention of other ports, e.g., https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/templates/controller-service-webhook.yaml#L31, to allow integration with other tools like Istio+Kiali.

[k8s-ci-robot]

@anders-swanson: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

If this is because istio/kiali can not use a portNumber, then are you thinking of submitting a PR for this ?

[anders-swanson]

Yes, I can submit a PR for this.

[longwuyuan]

Thank you. Please help by posting the config of every related objects using Kubectl describe and the screenshots of the end-user experience in the PR. I hope it will be optional and not a hard requirement to have a portName.

On a different note, do you know if this problem is related to istio/kiali . Just curious because wondering why its not been reported before.

[anders-swanson]

It is. Istio/Kiali have a requirement that every port follow the naming convention <protocol>[-name]. Without the protocol prefixing the port name, Kiali is unable to display metrics on mesh traffic.