Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the base nginx image for the 1.20.1 update #7189

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Update the base nginx image for the 1.20.1 update #7189

merged 2 commits into from
Jun 1, 2021

Conversation

strongjz
Copy link
Member

@strongjz strongjz commented May 31, 2021 •
edited
Loading

Adding the SHA from the latest build for custom Nginx base image for ingress, here. This updates the image to 1.20.1 for this issue here

What this PR does / why we need it:

Updates base nginx image to 1.20.1

Types of changes

Updates nginx image

Which issue/s this PR fixes

Fixes issue

How Has This Been Tested?

Local e2e test pass

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 31, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2021
@rikatz
Copy link
Contributor

rikatz commented May 31, 2021

/lgtm
/approve
Let's promote cloud build images next :)

Thanks!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 31, 2021
tao12345666333
tao12345666333 reviewed Jun 1, 2021
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, strongjz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@answer1991 answer1991 mentioned this pull request Jun 1, 2021
Closed
@answer1991
Copy link

/retest

1 similar comment
@strongjz
Copy link
Member Author

strongjz commented Jun 1, 2021

/retest

@rikatz
Copy link
Contributor

rikatz commented Jun 1, 2021

/override

@rikatz
Copy link
Contributor

rikatz commented Jun 1, 2021

/override Kubernetes (v1.16.15)

@rikatz
Copy link
Contributor

rikatz commented Jun 1, 2021

/override Kubernetes (v1.17.17)

@rikatz
Copy link
Contributor

rikatz commented Jun 1, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@rikatz: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rikatz
Copy link
Contributor

rikatz commented Jun 1, 2021

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jun 1, 2021
@k8s-ci-robot
Copy link
Contributor

@rikatz: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 96a87c7 into kubernetes:master Jun 1, 2021
@tao12345666333 tao12345666333 mentioned this pull request Jun 2, 2021
Closed
@strongjz strongjz deleted the update-nginx-base branch June 6, 2021 14:35
carnei-ro pushed a commit to carnei-ro/ingress-nginx that referenced this pull request Jun 7, 2021
@strongjz @carnei-ro
Update the base nginx image for the 1.20.1 update (kubernetes#7189)
5e8fe01 
* Update the base nginx image for the 1.20.1 update

* update the tests with the new nginx base image
qiqizjl pushed a commit to qiqizjl/ingress-nginx that referenced this pull request Jul 7, 2021
@strongjz @qiqizjl
Update the base nginx image for the 1.20.1 update (kubernetes#7189)
73746e2 
* Update the base nginx image for the 1.20.1 update

* update the tests with the new nginx base image
@tomasAlabes tomasAlabes mentioned this pull request Oct 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 left review comments

@cmluciano cmluciano Awaiting requested review from cmluciano

@rikatz rikatz Awaiting requested review from rikatz

Assignees

@tao12345666333 tao12345666333

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update nginx to mitigate CVE-2021-23017
5 participants
@strongjz @rikatz @k8s-ci-robot @answer1991 @tao12345666333