-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: release helm chart v3.34.0 #7258
Conversation
Signed-off-by: Jintao Zhang <[email protected]>
/area helm |
@@ -462,17 +462,17 @@ apiVersion: v1 | |||
kind: ServiceAccount | |||
metadata: | |||
name: ingress-nginx-admission | |||
namespace: ingress-nginx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we added the namespace field to the template, it will be fixed at this position.
/lgtm Thanks folks :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jintao Zhang [email protected]
What this PR does / why we need it:
Follow up #7256 (comment) make a new release for Helm chart.
Checklist: