feat: avoid-pdb-creation-when-default-backend-disabled-and-replicas-gt-1 #7420

marcportabellaclotet-mt · 2021-08-03T07:59:23Z

What this PR does / why we need it:

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

Pod disruption budgets should not be created when default-backend deployment creation is set to disabled and default backend replicas are set to more than 1.

How Has This Been Tested?

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I've read the CONTRIBUTION guide
I have added tests to cover my changes.
All new and existing tests passed.

k8s-ci-robot · 2021-08-03T07:59:30Z

@marcportabellaclotet-mt: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-08-03T07:59:31Z

Hi @marcportabellaclotet-mt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marcportabellaclotet-mt · 2021-08-03T08:01:08Z

/assign @rikatz

marcportabellaclotet-mt · 2021-08-03T08:03:29Z

Previous PR was closed due to some conflicts.

As commented by @rikatz , I am marking him to do a fast review

Signed-off-by: Bhumij Gupta <[email protected]>

* update pdb to v1 Signed-off-by: yuswift <[email protected]> * validate the version in PDB Signed-off-by: yuswift <[email protected]>

rikatz · 2021-08-05T22:31:32Z

/ok-to-test

… jobs (#7434) * helm: add feature to configure request and limit for container in createSecret and patchWebhook job Signed-off-by: Bhumij Gupta <[email protected]> * Remove empty line in helm template Signed-off-by: Bhumij Gupta <[email protected]> * Add test for admission webhook job container resources Signed-off-by: Bhumij Gupta <[email protected]> * Add new line character at the end of charts ci file Signed-off-by: Bhumij Gupta <[email protected]>

rikatz

@marcportabellaclotet-mt thanks for your PR

Just a minor thing here so we can follow k8s api deprecations, and we are good to go.

rikatz · 2021-08-05T22:32:49Z

charts/ingress-nginx/templates/default-backend-poddisruptionbudget.yaml

@@ -1,3 +1,4 @@
+{{- if .Values.defaultBackend.enabled -}}
 {{- if or (gt (.Values.defaultBackend.replicaCount | int) 1) (gt (.Values.defaultBackend.autoscaling.minReplicas | int) 1) }}
 apiVersion: policy/v1beta1


Let's verify what's the cluster version here.

See:
https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/templates/controller-poddisruptionbudget.yaml#L2

I think that I did the wrong thing, rebasing from main branch.
Sorry for the inconvenience.
It this is a problem, I will close the PR.

…into #7271-db-pdb-unneeded-creation

k8s-ci-robot · 2021-08-05T22:54:24Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marcportabellaclotet-mt
To complete the pull request process, please ask for approval from rikatz after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rikatz · 2021-08-06T17:43:01Z

yeah, there is some problem with the rebase
steps to rebase:

git fetch upstream/main
git rebase upstream/main
git push -f origin yourbranchname

marcportabellaclotet-mt · 2021-08-13T17:58:20Z

Sorry for the delay.
I rebased my branch, but this PR is not getting updated. Is there any further action I have to take? Create a new PR?
Again, sorry for the confusion, but I never worked with forks before, so I am a bit lost.

rikatz · 2021-08-21T12:40:22Z

@marcportabellaclotet-mt no need to ask sorry :)

So we are going to merge dev-v1 in the next days, and it's going to create huge rebases/conflicts, so I would wait before opening a new PR or working in this one :)

k8s-triage-robot · 2021-11-19T13:05:19Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2021-12-19T13:54:36Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

rikatz · 2021-12-23T22:08:32Z

/lifecycle frozen
Cycling back to this

k8s-ci-robot · 2021-12-23T22:08:33Z

@rikatz: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/lifecycle frozen
Cycling back to this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rikatz · 2021-12-29T18:43:13Z

/remove-lifecycle rotten

rikatz · 2021-12-29T18:44:31Z

charts/ingress-nginx/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: ingress-nginx
 # When the version is modified, make sure the artifacthub.io/changes list is updated
 # Also update CHANGELOG.md
-version: 3.34.0
+version: 3.35.0


Don't bump on this right now

rikatz · 2021-12-29T18:46:20Z

@marcportabellaclotet-mt there's something...strange with this PR :)

You are changing some e2e tests, + the deployment manifests.

Right now, can we stick only with the helm chart change?

Thanks!!

marcportabellaclotet-mt · 2021-12-30T11:03:31Z

This PR was opened a long time ago, and the only change I applied at the beginning was the one related to the helm chart.
I am not sure on how to proceed?

Fetch upstream : main?
Close PR and create a new one?
Thanks

rikatz · 2022-01-16T22:24:07Z

@marcportabellaclotet-mt

git fetch upstream main
git rebase upstream/main
git push origin your-branch

Should do the required.

Otherwise feel free to open a new PR and ping me here and in Slack (slack is better, I keep missing notifications here) and let's get this merged! :)

marcportabellaclotet-mt · 2022-01-17T09:52:33Z

Closed PR, added a new one with the required changes.

#8155

feat: avoid-pdb-creation-when-default-backend-disabled-and-replicas-gt-1

ff0b3c9

k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 3, 2021

k8s-ci-robot added the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Aug 3, 2021

k8s-ci-robot requested review from ChiefAlexander and cmluciano August 3, 2021 07:59

k8s-ci-robot assigned rikatz Aug 3, 2021

Marc Portabella and others added 7 commits August 3, 2021 10:04

fix: added-eol

f1f20bb

Add dev-v1 branch into helm releaser (#7424)

e70f040

Fixed chart version (#7423)

499ed16

Removed tabs and one extra-space (#7426)

3a1ab7c

Add http request test to annotaion ssl cipher test (#7431)

eb5c38d

Signed-off-by: Bhumij Gupta <[email protected]>

Bump PDB API version to v1 (#7421)

b1a71ad

* update pdb to v1 Signed-off-by: yuswift <[email protected]> * validate the version in PDB Signed-off-by: yuswift <[email protected]>

Add scope configuration check. (#6864)

46be938

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2021

rikatz requested changes Aug 5, 2021

View reviewed changes

Marc Portabella added 3 commits August 6, 2021 00:52

feat: avoid-pdb-creation-when-default-backend-disabled-and-replicas-gt-1

c62f88d

fix: added-eol

68e42fc

Merge remote-tracking branch 'origin/#7271-db-pdb-unneeded-creation' …

53e78a9

…into #7271-db-pdb-unneeded-creation

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 19, 2021

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 19, 2021

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 29, 2021

rikatz reviewed Dec 29, 2021

View reviewed changes

marcportabellaclotet-mt closed this Jan 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: avoid-pdb-creation-when-default-backend-disabled-and-replicas-gt-1 #7420

feat: avoid-pdb-creation-when-default-backend-disabled-and-replicas-gt-1 #7420

marcportabellaclotet-mt commented Aug 3, 2021

k8s-ci-robot commented Aug 3, 2021

k8s-ci-robot commented Aug 3, 2021

marcportabellaclotet-mt commented Aug 3, 2021 •

edited

Loading

marcportabellaclotet-mt commented Aug 3, 2021

rikatz commented Aug 5, 2021

rikatz left a comment

rikatz Aug 5, 2021

marcportabellaclotet-mt Aug 5, 2021

k8s-ci-robot commented Aug 5, 2021

rikatz commented Aug 6, 2021

marcportabellaclotet-mt commented Aug 13, 2021

rikatz commented Aug 21, 2021

k8s-triage-robot commented Nov 19, 2021

k8s-triage-robot commented Dec 19, 2021

rikatz commented Dec 23, 2021

k8s-ci-robot commented Dec 23, 2021

rikatz commented Dec 29, 2021

rikatz Dec 29, 2021

rikatz commented Dec 29, 2021

marcportabellaclotet-mt commented Dec 30, 2021

rikatz commented Jan 16, 2022

marcportabellaclotet-mt commented Jan 17, 2022

feat: avoid-pdb-creation-when-default-backend-disabled-and-replicas-gt-1 #7420

feat: avoid-pdb-creation-when-default-backend-disabled-and-replicas-gt-1 #7420

Conversation

marcportabellaclotet-mt commented Aug 3, 2021

What this PR does / why we need it:

Types of changes

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

k8s-ci-robot commented Aug 3, 2021

k8s-ci-robot commented Aug 3, 2021

marcportabellaclotet-mt commented Aug 3, 2021 • edited Loading

marcportabellaclotet-mt commented Aug 3, 2021

rikatz commented Aug 5, 2021

rikatz left a comment

Choose a reason for hiding this comment

rikatz Aug 5, 2021

Choose a reason for hiding this comment

marcportabellaclotet-mt Aug 5, 2021

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 5, 2021

rikatz commented Aug 6, 2021

marcportabellaclotet-mt commented Aug 13, 2021

rikatz commented Aug 21, 2021

k8s-triage-robot commented Nov 19, 2021

k8s-triage-robot commented Dec 19, 2021

rikatz commented Dec 23, 2021

k8s-ci-robot commented Dec 23, 2021

rikatz commented Dec 29, 2021

rikatz Dec 29, 2021

Choose a reason for hiding this comment

rikatz commented Dec 29, 2021

marcportabellaclotet-mt commented Dec 30, 2021

rikatz commented Jan 16, 2022

marcportabellaclotet-mt commented Jan 17, 2022

marcportabellaclotet-mt commented Aug 3, 2021 •

edited

Loading