-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm - Enable configuring request and limit for containers in webhook jobs #7434
Helm - Enable configuring request and limit for containers in webhook jobs #7434
Conversation
…ateSecret and patchWebhook job Signed-off-by: Bhumij Gupta <[email protected]>
@bhumijgupta: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @bhumijgupta. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
charts/ingress-nginx/templates/admission-webhooks/job-patch/job-createSecret.yaml
Outdated
Show resolved
Hide resolved
@bhumijgupta thanks for the PR. Left some minor comment. Also, would be good to add some e2e test, which would be basically adding a new file in https://github.com/kubernetes/ingress-nginx/tree/main/charts/ingress-nginx/ci with some random values that should work in resources for both files :) |
/ok-to-test |
Signed-off-by: Bhumij Gupta <[email protected]>
Signed-off-by: Bhumij Gupta <[email protected]>
Signed-off-by: Bhumij Gupta <[email protected]>
Added test and addressed the review comments |
/kind feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I need to test locally later
CI is catching stuff :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bhumijgupta, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… jobs (kubernetes#7434) * helm: add feature to configure request and limit for container in createSecret and patchWebhook job Signed-off-by: Bhumij Gupta <[email protected]> * Remove empty line in helm template Signed-off-by: Bhumij Gupta <[email protected]> * Add test for admission webhook job container resources Signed-off-by: Bhumij Gupta <[email protected]> * Add new line character at the end of charts ci file Signed-off-by: Bhumij Gupta <[email protected]>
What this PR does / why we need it:
This PR adds two additional fields in helm values namely
controller.admissionWebhooks.createSecretJob.resources
andcontroller.admissionWebhooks.patchWebhookJob.resources
that can be used to configure the container resources limits and requests for job-createSecret and job-patchWebhook.By default, the values are empty object, and no explicit resource limits are set by the user.
Types of changes
Which issue/s this PR fixes
Fixes #7105
How Has This Been Tested?
Ran automated tests
make kind-e2e-chart-tests
and manually deployed the helm chart and checked resources request and limits in the jobsChecklist: