-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan with govulncheck and upload SARIF report #9474
Conversation
Hi @jaehnri. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jaehnri The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jaehnri can you rebase please |
- name: Scan for Vulnerabilities in Code | ||
uses: Templum/[email protected] | ||
with: | ||
go-version: 1.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have updated the go tool chain to v1.20
Didn't we need to rebuild the controller, wait and dgb with symbols to get govulncheck to work? |
@@ -57,6 +57,16 @@ ${GO_BUILD_CMD} \ | |||
-buildvcs=false \ | |||
-o "${TARGETS_DIR}/nginx-ingress-controller" "${PKG}/cmd/nginx" | |||
|
|||
echo "Building ${PKG}/cmd/nginx with Go's symbol table" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the difference between scannable-nginx-ingress-controller
and nginx-ingress-controller
build options?
/kind feature |
What this PR does / why we need it:
This PR adds an additional CI step that runs
govulncheck
against the go executable.govulncheck
reports known vulnerabilities that affect Go code. It uses static analysis of source code or a binary's symbol table to narrow down reports to only those that could affect the application.Then, it uploads a SARIF reports that integrates with Github's code scanning API.
Types of changes
Which issue/s this PR fixes
fixes #9096
How Has This Been Tested?
I've created an equivalent PR in my own fork. There, it is possible to see that the new step ran and uploaded the SARIF report, which resulted in a new check called "Code scanning results".
Checklist:
Does my pull request need a release note?
Any user-visible or operator-visible change qualifies for a release note. This could be a:
No release notes are required for changes to the following:
For more tips on writing good release notes, check out the Release Notes Handbook