Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release docs for Controller v1.6.3 and Helm v4.5.0 #9614

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

strongjz
Copy link
Member

Signed-off-by: James Strong [email protected]

What this PR does / why we need it:

1.6.3 Release notes

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 14, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority area/docs area/helm Issues or PRs related to helm charts size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 14, 2023
@strongjz strongjz requested review from rikatz, longwuyuan and tao12345666333 and removed request for ElvinEfendi and ChiefAlexander February 14, 2023 00:46
@tao12345666333
Copy link
Member

/go/src/k8s.io/ingress-nginx/charts/ingress-nginx/values.yaml
  622:30    error    too few spaces before comment  (comments)
  624:30    error    too few spaces before comment  (comments)

------------------------------------------------------------------------------------------------------------------------
 ✖︎ ingress-nginx => (version: "4.5.0", path: "/go/src/k8s.io/ingress-nginx/charts/ingress-nginx") > Error waiting for process: exit status 1
------------------------------------------------------------------------------------------------------------------------
Error: Error linting charts: Error processing charts
Error linting charts: Error processing charts
Error: Process completed with exit code 1.

some lint errors.

@strongjz strongjz force-pushed the release-1.6.3 branch 2 times, most recently from 25a2288 to 5d3b669 Compare February 14, 2023 01:14
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: strongjz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [strongjz,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 80fd69e into kubernetes:main Feb 14, 2023
@strongjz strongjz deleted the release-1.6.3 branch April 5, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants