Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a new home for the helm chart #1153

Closed
mrueg opened this issue Jun 4, 2020 · 9 comments · Fixed by #1237
Closed

Provide a new home for the helm chart #1153

mrueg opened this issue Jun 4, 2020 · 9 comments · Fixed by #1237
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mrueg
Copy link
Member

mrueg commented Jun 4, 2020

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened:
https://github.com/helm/charts#deprecation-timeline helm/charts repository which currently hosts the kube-state-metrics chart will become obsolete in Nov 2020.
What you expected to happen:
Figure out a new place for the kube-state-metrics chart. Ideally, it could live in this repository as a directory (similar to the jsonnet mixin) and get published on helm hub.
Currently @tariq1890 and I are maintainers of the helm/charts chart and could maintain it here as well.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 4, 2020
@lilic
Copy link
Member

lilic commented Jun 11, 2020

cc @tariq1890

@tariq1890
Copy link
Contributor

I am okay with adding the helm chart to this repository. Thoughts @brancz and @lilic ?

@brancz
Copy link
Member

brancz commented Jun 15, 2020

I'd be fine with that as well, ideally we could even generate it from the jsonnet code we have, but I wouldn't block it if it wasn't. The only think that I would be a bit strict about is that everything has to be equally automated as the jsonnet things we have, so that releasing a new version doesn't have any other steps than the current VERSION file bump.

@lilic
Copy link
Member

lilic commented Jun 15, 2020

Yes fine as well, not to familiar with Helm charts so don't think I can contribute much to it, but no objections.

@mrueg
Copy link
Member Author

mrueg commented Jun 15, 2020

Would you be comfortable with a contrib/ folder structure that includes a charts subfolder? This could potentially include jsonnet and other deployment options as well. If we can generate a helm chart from jsonnet or at least synchronize it, that would be perfect. A goal would be to publish it via CI to https://hub.helm.sh/charts/stable/kube-state-metrics (stable namespace would be replaced with a different one)

@brancz
Copy link
Member

brancz commented Jun 19, 2020

That's effectively what we used to have, and that didn't work out well. I'm all for synchronizing the chart with jsonnet though regardless of where it's located! :)

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 17, 2020
@mrueg
Copy link
Member Author

mrueg commented Sep 17, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 17, 2020
@scottrigby
Copy link
Contributor

I have started a draft PR for this: #1237

Looking for feedback on the to-do items I added, before I do too much more on this. Happy to finish after feedback 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants