Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire context to logs command and add interrupt handler #127503

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Wire context to logs command and add interrupt handler #127503

merged 2 commits into from
Oct 22, 2024
+29 −21

Conversation

ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Sep 20, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR adds interrupt handler into kubectl logs command to gracefully shutdown process when exit signals are captured.

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#1647

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 20, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 20, 2024
@ardaguclu
Copy link
Member Author

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 20, 2024
@soltysh
Copy link
Contributor

soltysh commented Oct 22, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 22, 2024
soltysh
soltysh approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a9d1c4cb218c4eab888d6a8463d2949299238a2c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5826868 into kubernetes:master Oct 22, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 22, 2024
@ardaguclu ardaguclu deleted the logs-handle-signals branch October 22, 2024 18:55
scott-grimes pushed a commit to scott-grimes/kubernetes that referenced this pull request Oct 23, 2024
@ardaguclu @scott-grimes
Wire context to logs command and add interrupt handler (kubernetes#12…
74a353d 
…7503)

* Wire context to logs command and add interrupt handler

* Move conditional outside of interrupt handler
richabanker pushed a commit to richabanker/kubernetes that referenced this pull request Oct 29, 2024
@ardaguclu @richabanker
Wire context to logs command and add interrupt handler (kubernetes#12…
a27f1b5 
…7503)

* Wire context to logs command and add interrupt handler

* Move conditional outside of interrupt handler
felipeagger pushed a commit to felipeagger/kubernetes that referenced this pull request Nov 6, 2024
@ardaguclu @felipeagger
Wire context to logs command and add interrupt handler (kubernetes#12…
8a3599c 
…7503)

* Wire context to logs command and add interrupt handler

* Move conditional outside of interrupt handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@brianpursley brianpursley Awaiting requested review from brianpursley

@seans3 seans3 Awaiting requested review from seans3

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG CLI
Status: Done
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.

Pressing ctrl+\ results in a panic? or segfault?
3 participants
@ardaguclu @soltysh @k8s-ci-robot