Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow set ImageRepository for kubeadm init #3166

Closed
bcho opened this issue Sep 26, 2018 · 3 comments · Fixed by #3714
Closed

Allow set ImageRepository for kubeadm init #3166

bcho opened this issue Sep 26, 2018 · 3 comments · Fixed by #3714
Labels
area/localization Issues relating to how minikube runs around the world co/kubeadm Issues relating to kubeadm help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@bcho
Copy link

bcho commented Sep 26, 2018 •
edited
Loading

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Please provide the following details:

Environment:

minikube version: v0.28.2

OS:
cat: /etc/os-release: No such file or directory

VM driver:
    "DriverName": "hyperkit",

ISO version
        "Boot2DockerURL": "file:///path/to/.minikube/cache/iso/minikube-v0.28.1.iso",

Can the kubeadm bootstrapper adds a configuration option support for ImageRepository, which enables setting different image base repository. This feature will help developers who are having difficulties to connect to k8s.gcr.io (namely, China), as long as they can set the repository prefix to self managed proxies.
@bcho
Copy link
Author

bcho commented Sep 26, 2018

But looks like we have to migrate the kubeadm configuration to v1alpha2 first :/

@dlorenc
Copy link
Contributor

dlorenc commented Sep 26, 2018

cc @tstromberg

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. co/kubeadm Issues relating to kubeadm labels Sep 27, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2018
@tstromberg tstromberg added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/localization Issues relating to how minikube runs around the world help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 23, 2019
@laozc laozc mentioned this issue Feb 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/localization Issues relating to how minikube runs around the world co/kubeadm Issues relating to kubeadm help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --image-repository flag so that users can select an alternative repository mirror laozc/minikube
5 participants
@tstromberg @dlorenc @bcho @k8s-ci-robot @fejta-bot