Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: adjust e2e presubmit jobs #33330

Merged
merged 1 commit into from
Aug 16, 2024
Merged

etcd: adjust e2e presubmit jobs #33330

merged 1 commit into from
Aug 16, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Aug 16, 2024

  • Don't set them as optional, as the jobs have been stable, according to TestGrid.
  • Set the RAM requests/limits to 4Gi, as based on the Grafana stats, ARM and AMD jobs have been using around 1Gi, so cutting the resources in half should be enough.

ARM resources are to be adjusted, as I need to confirm with sig-infra where we can find the stats for the cluster where the jobs run.

Part of #32754 / kubernetes/k8s.io#6102

@ivanvc
etcd: adjust e2e presubmit jobs
37f27e4 
* Don't set them as optional, as the jobs have been stable, according to
  TestGrid.
* Set the RAM requests/limits to 4Gi, as based on the Grafana stats, ARM
  and AMD jobs have been using around 1Gi, so cutting the resources in
  half should be enough.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 16, 2024
ivanvc added a commit to ivanvc/etcd that referenced this pull request Aug 16, 2024
@ivanvc
github/workflows: remove e2e jobs
ed28d93 
These jobs have been long running on the prow infrastructure by the work
from the pull request kubernetes/test-infra#31257. By having them as
required (kubernetes/test-infra#33330), it should be safe to remove the
GitHub actions.

Signed-off-by: Ivan Valdes <[email protected]>
jmhbnz
jmhbnz approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Much appreciated @ivanvc

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7956a05 into kubernetes:master Aug 16, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ivanvc: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-presubmits.yaml using file config/jobs/etcd/etcd-presubmits.yaml

In response to this:

  • Don't set them as optional, as the jobs have been stable, according to TestGrid.
  • Set the RAM requests/limits to 4Gi, as based on the Grafana stats, ARM and AMD jobs have been using around 1Gi, so cutting the resources in half should be enough.

ARM resources are to be adjusted, as I need to confirm with sig-infra where we can find the stats for the cluster where the jobs run.

Part of #32754 / kubernetes/k8s.io#6102

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc ivanvc deleted the update-etcd-e2e-presubmits branch August 16, 2024 14:50
ivanvc added a commit to ivanvc/etcd that referenced this pull request Aug 16, 2024
@ivanvc
github/workflows: remove e2e jobs
fbd4fa4 
These jobs have been long-running on the prow infrastructure, thanks to
the work from the pull request kubernetes/test-infra#31257. Since they
are required (kubernetes/test-infra#33330), it should be safe to remove
the GitHub actions.

Signed-off-by: Ivan Valdes <[email protected]>
@ivanvc ivanvc mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@wenjiaswe wenjiaswe Awaiting requested review from wenjiaswe

Assignees

@jmhbnz jmhbnz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanvc @k8s-ci-robot @jmhbnz