-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken link to latest Kubernetes documentation #16066
Comments
@sftim I can't reproduce -- Chrome on Mac Mojave. Markup on the site looks OK (no null
|
Leaving my previous comment in place, but correcting it. Yup, reproduced. Given it's the latest version minus only one, seems a fairly high priority -- also bc seems likely that if we don't fix it'll repro for the next released version. |
/priority important-longterm |
Also, compare the difference between 1.13 and 1.14 behavior on the
I mention it because v1.13 behaves correctly but also returns a null href: <section id="deprecationWarning">
<main>
<div class="content deprecation-warning">
<h3>
Kubernetes v1.13
documentation is no longer actively maintained. The version you are currently viewing is a static snapshot. For up-to-date documentation, see the
<a href="">latest version.</a>
</h3>
</div>
</main>
</section> |
@jimangel I have an intution 🔮 this may involve a fix to line 8 on the same order of fixing line 6: Kubernetes {{ .Page.Param "version" }}
{{ T "deprecation_warning" }}
<a href="{{ .Site.Params.currentUrl }}">{{ T "latest_version" }}</a> UPDATE: ...Or more like #12743. UPDATE: ...Or neither. I'm stumped. |
After further testing, I notice one difference: at the fully qualified domain name (FQDN) only — https://v1-13.docs.kubernetes.io — the source populates the <section id="deprecationWarning">
<main>
<div class="content deprecation-warning">
<h3>
Kubernetes v1.13
documentation is no longer actively maintained. The version you are currently viewing is a static snapshot. For up-to-date documentation, see the
<a href="https://kubernetes.io/docs/home/">latest version.</a>
</h3>
</div>
</main>
</section> Navigating to other URLs on the site (any URL with a path after the FQDN) shows that the shortcode fails to render/populate the |
@rlenferink @kbarnard10 @BenTheElder 👋 Any Hugo thoughts here? |
🤔 this does look a lot like gohugoio/hugo#5615 |
@BenTheElder It does--and gohugoio/hugo#5615 was solved in a release more recent than 0.53. That's a potential avenue for testing as well. |
Bingo--upgrading Hugo to 0.57.2 solves it. @BenTheElder re:this thread, Exhibit A! |
Excellent :-) |
/kind bug |
Revised the issue description as v1.16 is now out. |
This is a Bug Report
Problem:
https://v1-15.docs.kubernetes.io/docs/ hyperlinks to the latest documentation, except that the link is actually to https://v1-14.docs.kubernetes.io/docs/ (because the
href
is null).(oops!)
Here's the markup:
Proposed Solution:
Fix the link so that it takes readers to https://kubernetes.io/docs/
Pages to Update:
https://v1-15.docs.kubernetes.io/docs/
https://v1-14.docs.kubernetes.io/docs/
https://v1-13.docs.kubernetes.io/docs/
The text was updated successfully, but these errors were encountered: