Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect advice about creating a secret #16004

Merged
merged 3 commits into from
Sep 26, 2019
Merged

Fix incorrect advice about creating a secret #16004

merged 3 commits into from
Sep 26, 2019

Commits on Aug 22, 2019

  1. Fix incorrect advice about creating a secret 

    The existing command does not use code style as required by the style
guide and it is incorrect as rendered. Also, there's an easier way to do
this.
    @verb
    verb committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    3408f0c View commit details
    Browse the repository at this point in the history

  2. Add reviewer suggested improvement for secret escaping 

    Adding sftim's suggestion phrasing explanation of escaping shell special characters.

Co-Authored-By: Tim Bannister <[email protected]>
    @verb @sftim
    verb and sftim committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    ec2ee9a View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2019

  1. Make secret escaping instructions consistent

    @verb
    verb committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    2478894 View commit details
    Browse the repository at this point in the history