Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: update upgrade documentation for 1.16 #16015

Merged
merged 1 commit into from
Sep 6, 2019
Merged

kubeadm: update upgrade documentation for 1.16 #16015

merged 1 commit into from
Sep 6, 2019

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Aug 22, 2019 •
edited
Loading

Move to a single document for upgrades!

/sig cluster-lifecycle
/priority important-soon

tracked at:
kubernetes/kubeadm#1739

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 22, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 22, 2019 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 82680a5

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5d67e50181e5e20008a5df78

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2019
@neolit123 neolit123 mentioned this pull request Aug 22, 2019
Closed
3 tasks
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 22, 2019
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2019
@xiangpengzhao
Copy link
Contributor

/approve
/hold
@neolit123 feel free to /hold cancel after you finish the doc :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2019
@xiangpengzhao
Copy link
Contributor

Oops! I'm not be able to approve PRs for 1.16 branch :(
/assign @jimangel
for approval :)

@simplytunde
Copy link
Contributor

/milestone 1.16

@k8s-ci-robot k8s-ci-robot added this to the 1.16 milestone Aug 28, 2019
@neolit123 neolit123 changed the title kubeadm: update reference documentation for 1.16 kubeadm: update upgrade documentation for 1.16 Aug 29, 2019
@neolit123 neolit123 force-pushed the 1.16-kubeadm-update-upgrade-docs branch from 7f8f173 to 6990b07 Compare August 29, 2019 00:48
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2019
@neolit123
Copy link
Member Author

/assign @fabriziopandini
@kubernetes/sig-cluster-lifecycle-pr-reviews
ready for tech review.

fabriziopandini
fabriziopandini suggested changes Aug 29, 2019
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neolit123 thanks for this upgrade. +💯 for cleaning up docs for old releases.
Only two small nit to be addressed from my side

content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md Outdated Show resolved Hide resolved
@neolit123
kubeadm: update the upgrade documentation for 1.16
82680a5 
Move to a single document for upgrades!
@neolit123 neolit123 force-pushed the 1.16-kubeadm-update-upgrade-docs branch from 6990b07 to 82680a5 Compare August 29, 2019 14:45
@neolit123
Copy link
Member Author

@fabriziopandini updated.

fabriziopandini
fabriziopandini approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, xiangpengzhao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member Author

this has passed tech review and needs docs review / approval.
/assign @jimangel
PTAL.

@simplytunde
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 520381f into kubernetes:dev-1.16 Sep 6, 2019
@fabriziopandini fabriziopandini mentioned this pull request Sep 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini approved these changes

@mikedanese mikedanese Awaiting requested review from mikedanese

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@jimangel jimangel

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.
8 participants
@neolit123 @k8sio-netlify-preview-bot @fejta-bot @xiangpengzhao @simplytunde @k8s-ci-robot @fabriziopandini @jimangel